Record where an interaction was acknowledged first#2685
Draft
freya022 wants to merge 2 commits intodiscord-jda:masterfrom
Draft
Record where an interaction was acknowledged first#2685freya022 wants to merge 2 commits intodiscord-jda:masterfrom
freya022 wants to merge 2 commits intodiscord-jda:masterfrom
Conversation
freya022
force-pushed
the
feature/better-ack-exception
branch
from
4ef96f8 to
ad4e2fb
Compare
Activated after an exception is thrown, for minimal performance impact
freya022
force-pushed
the
feature/better-ack-exception
branch
from
ad4e2fb to
c7810c1
Compare
freya022
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
This PR enables saving stack traces when an user acknowledges an interaction, helping the user find out where their interaction was acknowledged first, in addition to where it tried to acknowledge from.
The stack traces are only saved after the first acknowledgement exception is thrown, and will be disabled when: