Conversation
wolfgangwalther
approved these changes
Sep 7, 2025
wolfgangwalther
left a comment
wolfgangwalther
left a comment
Contributor
There was a problem hiding this comment.
Builds and tests pass for GHC 9.6, GHC 9.8 and GHC 9.10 in Nixpkgs.
Trying with GHC 9.12 I get this:
Encountered missing or private dependencies:
time >=1.8.0.2 && <1.13
When I ignore that constraint, it builds and tests fine with GHC 9.12 as well. Might want to relax that constraint at the same time.
Owner
Author
|
@wolfgangwalther thanks for the review and tests. |
diogob
marked this pull request as ready for review
September 7, 2025 15:17
Owner
Author
|
I forgot to relax the library dependency on this PR but will update before releasing the new version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update should take care of #108