Skip to content

Conversation

@pascal-hofmann
Copy link
Collaborator

@pascal-hofmann pascal-hofmann commented Sep 13, 2022

This ports the ec_deployment_traffic_filter_association resource to terraform-provider-framework.

A migration test is still missing. This will be an acceptance test, because mocking will not work with an old, external provider.

Description

Related Issues

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@pascal-hofmann
Copy link
Collaborator Author

pascal-hofmann commented Sep 13, 2022

@dimuon This branch is based on the latest feature/530/ec-deployment. Should I remove the unneeded changes from there so we can merge into feature/530/migrate-to-plugin-framework without the deployment changes?

@pascal-hofmann pascal-hofmann force-pushed the feature/530/ec-trafficfilterassoc branch 2 times, most recently from 9b90625 to 56268b8 Compare September 14, 2022 04:46
@pascal-hofmann pascal-hofmann force-pushed the feature/530/ec-trafficfilterassoc branch from 56268b8 to d28e9f4 Compare September 14, 2022 04:55
@pascal-hofmann
Copy link
Collaborator Author

Closing in favor or #5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants