Fix benchmark #577
Open
Fix benchmark #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThierryBerger
commented
Aug 30, 2024
| pub fn custom_bencher(steps: usize, setup: impl Fn(&mut App)) { | ||
| let mut app = default_app(); | ||
| setup(&mut app); | ||
| #[cfg(feature = "visual")] |
Contributor
Author
There was a problem hiding this comment.
add explaination to readme
sebcrozet
approved these changes
Sep 6, 2024
Member
sebcrozet
left a comment
sebcrozet
left a comment
There was a problem hiding this comment.
Just need the README update for the visual feature, but looking good overall. Thanks!
bevy_rapier_benches3d/Cargo.toml
Outdated
| rapier3d = { features = ["profiler"], version = "0.22" } | ||
| bevy_rapier3d = { version = "0.27", path = "../bevy_rapier3d" } | ||
| bevy = { version = "0.14", default-features = false } | ||
| rapier3d = { features = ["profiler"], version = "0.22" } |
Member
There was a problem hiding this comment.
This reminds me that I’d like to revisit that profiler thing in rapier to switch so something less manual. Like switching the tracy or something. (This is unrelated to this PR though.)
ThierryBerger
commented
May 18, 2025
| and outputs them at the end. | ||
|
|
||
| ```sh | ||
| cargo run --release --bin bench |
Contributor
Author
There was a problem hiding this comment.
Running cargo run --release --bin bench from the root brings all dependencies, but running this from bevy_rapier_benches3d brings only the needed ones, this may be worth a note (and I'd like to understand why.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #553
Transformwasn't enough to place correctly the cubes, which made the scene having way too many exploding collisions, which was the main source of bad performance detected in Added initial benchmarks #551.bevy_winitdoesn´t support window recreaction.