Skip to content

Comments

Reshuffle case search feature flags#37397

Open
esoergel wants to merge 54 commits intomasterfrom
es/case-search-ffs
Open

Reshuffle case search feature flags#37397
esoergel wants to merge 54 commits intomasterfrom
es/case-search-ffs

Conversation

@esoergel
Copy link
Contributor

@esoergel esoergel commented Feb 19, 2026

Product Description

Technical Summary

Collaborative effort from @MartinRiese and myself - our individual PRs are all being approved and merged into this branch, so we can release them together.

TODOs:

Feature Flag

Safety Assurance

Safety story

Automated test coverage

QA Plan

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

esoergel and others added 22 commits January 29, 2026 11:54
Guessing this was just an oversight - the template migration is
complete, so I don't believe anything references the B3 version anymore
We are transitioning the a smaller set of feature flags
for case search. Before migrating to code to use the flags,
enable them on the domains that already use the features.
"parent/" can show up in default searches too. Both the
name and value.

geocoder fields don't need hidden check
 Move the multiselect and autoselect checkboxes behind the advanced flag
Move advanced case search settings behind FF
@esoergel esoergel marked this pull request as ready for review February 19, 2026 12:04
@esoergel esoergel added the product/feature-flag Change will only affect users who have a specific feature flag enabled label Feb 19, 2026
Add command to enable new case search FF
* "Include related cases in search results" is now under "Case Search:
  Related Lookups"
* "Case property with additional case id to add to results" is now under
  "Advanced Case Search"
@MartinRiese MartinRiese requested a review from a team as a code owner February 19, 2026 17:38
MartinRiese and others added 19 commits February 19, 2026 12:51
Use correct FF in tests
Put case search icon and audio behind simple FF
It was one time use and does not make sense with the new case search FFs
anyways
Move case search features behind new FF
With SSCS (Split Screen Case Search) now the default behavior, the
search_again_label is no longer needed. This removes all references to
search_again_label and CaseSearchAgainLabel throughout the codebase.

Changes:
- Remove CaseSearchAgainLabel class and search_again_label/again_label
  properties from CaseSearch model
- Remove search_again_label from views (GET/POST endpoints, media handling)
- Remove search_again_label locale string generation
- Remove search_again_label from media collection and renaming
- Remove search_again_label from translation upload/download modules
- Remove search_again_label from JavaScript (case_claim.js)
- Update test fixtures and assertions to no longer expect search_again
  functionality
- Clean up test data (plant_care_app.json)

The search_again_label was previously used to provide a "Search Again"
button on search results, but with SSCS this is no longer generated.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Remove SPLIT_SCREEN_CASE_SEARCH toggle checks from JavaScript and make
split-screen case search always enabled, aligning with backend changes.

The SPLIT_SCREEN_CASE_SEARCH toggle is frozen (TAG_FROZEN) and will be
removed. The backend (commit 6f34a21) already generates split-screen
suite XML unconditionally, so the JavaScript should match this behavior.

Changes:
- Remove toggle check from isSidebarEnabled() function in utils.js
- Always enable split-screen UI when case search has data to display
- Update analytics tracking to always report split-screen as enabled
- Remove splitScreenToggleEnabled property and all dead code paths
- Remove non-split-screen search container from case list template
- Remove toggle stub and obsolete test from split_screen_case_search_spec

The split-screen UI is now always available for domains with case search,
controlled by the parent toggle SYNC_SEARCH_CASE_CLAIM (Simple Case Search).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The backend no longer checks this toggle, so test decorators and toggle
dict entries are dead code.

- Remove @flag_enabled('SPLIT_SCREEN_CASE_SEARCH') from Python tests
- Remove SPLIT_SCREEN_CASE_SEARCH from JS test toggle dicts
- Fix search_on_clear tests to use correct CASE_SEARCH_ADVANCED toggle

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
No more search again action we need to find
This just means we can roll this out without coordinating with
Formplayer.  It should be removed once the corresponding change is made
over there.
Shuffle case search property features behind new FF
@esoergel
Copy link
Contributor Author

esoergel commented Feb 24, 2026

Merging #37324 into this PR without approval - we'll need post-facto approval of that PR before this one is considered mergeable.
Likewise for the last two commits I added to #37340
@MartinRiese can you do that when you get back online?

@esoergel esoergel added the awaiting QA QA in progress. Do not merge label Feb 24, 2026
Move split screen case search under simple case search
@esoergel esoergel requested a review from nospame as a code owner February 24, 2026 15:30
@dimagimon dimagimon added the Risk: Medium Change affects files that have been flagged as medium risk. label Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting QA QA in progress. Do not merge product/feature-flag Change will only affect users who have a specific feature flag enabled Risk: Medium Change affects files that have been flagged as medium risk.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants