Open
Conversation
dependabot
bot
force-pushed
the
dependabot/uv/stripe-14.2.0
branch
from
f1326ef to
2dfdede
Compare
Bumps [stripe](https://github.com/stripe/stripe-python) from 13.2.0 to 14.2.0. - [Release notes](https://github.com/stripe/stripe-python/releases) - [Changelog](https://github.com/stripe/stripe-python/blob/master/CHANGELOG.md) - [Commits](stripe/stripe-python@v13.2.0...v14.2.0) --- updated-dependencies: - dependency-name: stripe dependency-version: 14.2.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/uv/stripe-14.2.0
branch
from
2dfdede to
76de8ea
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| source = { registry = "https://pypi.org/simple" } | ||
| dependencies = [ | ||
| { name = "requests" }, | ||
| { name = "typing-extensions" }, |
There was a problem hiding this comment.
Bug: The major version upgrade of the Stripe SDK to v14.3.0 might break payment processing, and the integration tests that would catch this are skipped in CI.
Severity: HIGH
Suggested Fix
Before merging, either manually run the Stripe integration tests in an environment with API keys to confirm that payment processing still works, or find official documentation/changelogs for the Stripe Python SDK v14.3.0 that explicitly confirms the card parameter for stripe.Charge.create() is still supported.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: uv.lock#L3292
Potential issue: The update to `stripe` v14.3.0, a major version change, may introduce a
breaking change. The `charge_through_stripe` function relies on passing a `card`
parameter to `stripe.Charge.create()`. It is uncertain if this parameter is still
supported in the new version, and the integration tests that would verify this
functionality are intentionally skipped in the CI environment for this pull request. If
this parameter has been removed, all payment processing will fail in production after
deployment, as the breaking change would not be caught by the automated test suite.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps stripe from 13.2.0 to 14.2.0.
Release notes
Sourced from stripe's releases.
... (truncated)
Changelog
Sourced from stripe's changelog.
... (truncated)
Commits
75d921fBump version to 14.2.00a0a156Update generated code for v2152 and (#1721)9d6fbafUpdate generated code for v2151 and (#1720)7d55cf4Add explicit permissions to GitHub workflows (#1715)998740cDelete API_VERSION file as it is no longer needed (#1712)5687fb2Copy API_VERSION to CODEGEN_VERSION (#1706)96545ffFix DeprecationWarning when encoding StripeObject metadata (fixes #1651) (#1687)3cda55eUpdate ci to run on Python 3.14 as well (#1703)493aeabBump version to 14.1.010dd396Do not apply a mark to async_http_client fixture (#1700)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)