Partial refactor and other improvements #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several significant changes to the build configuration, Docker setup, and command-line argument handling. The changes improve the build process, enhance the Docker configuration, and refactor the command-line argument parsing to use the
viperlibrary for better configuration management.Build Configuration Changes:
.goreleaser.yaml: Added new build flags to include license-related environment variables. [1] [2].goreleaser.yaml: Introduced Docker configurations for building and tagging Docker images for multiple architectures (amd64 and arm64).Docker Setup Improvements:
Dockerfile: Refactored to create a non-root user, install certificates, set up application directories, and add a health check endpoint.Command-line Argument Handling:
cmd/common.go: Refactored command-line flag parsing to useviperfor binding flags to configuration variables, improving flexibility and maintainability. [1] [2]Error Handling Enhancements:
cmd/common.go: Improved error handling in therequireLicensefunction to provide more informative error messages.Testing Additions:
cmd/common_test.go: Added comprehensive tests for command execution, ensuring robustness and correctness of the new command-line argument handling.