pgremapper: Consider upmaps when reordering up sets.#7
Merged
Conversation
…esn't make any changes.
Consider the following upmap entry:
```
{
"pgid": "1.38f",
"mappings": [
{
"from": 51,
"to": 3
},
{
"from": 19,
"to": 11
}
]
},
```
And the following PG state:
```
{
"pgid": "1.38f",
"state": "active+remapped+backfill_wait",
"up": [
3,
66,
11
],
"acting": [
3,
19,
39
],
"up_primary": 3,
"acting_primary": 3
},
```
Prior to this change, pgremapper would attempt to remap 66->19, which
would conflict with the existing mapping 19->11. After this change,
pgremapper is wise enough to use the upmap item to realize that 19 and
11 are paired and re-order the up set accordingly for proper processing.
Matt1360
approved these changes
Jun 17, 2021
Contributor
Author
|
This addresses #5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider the following upmap entry:
And the following PG state:
Prior to this change, pgremapper would attempt to remap 66->19, which would conflict with the existing mapping 19->11. After this change, pgremapper is wise enough to use the upmap item to realize that 19 and 11 are paired and re-order the up set accordingly for proper processing.