Skip to content

mappingstate: add distinctive dirty state#15

Merged
alram merged 2 commits into
mainfrom
pgremapper-dirty-change
Oct 28, 2021
Merged

mappingstate: add distinctive dirty state#15
alram merged 2 commits into
mainfrom
pgremapper-dirty-change

Conversation

@alram

@alram alram commented Oct 21, 2021

Copy link
Copy Markdown

Make a distinction when an operation is possible but nobackfill reservation is available vs no operation possible

And another commit to update README

@baergj baergj changed the title mappingstate: add distintive dirty state mappingstate: add distinctive dirty state Oct 22, 2021

@baergj baergj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure looks great - just a few tweaks needed.

Comment thread README.md
Comment thread main.go
Comment thread main.go Outdated
Comment thread mappingstate.go Outdated
@alram

alram commented Oct 25, 2021

Copy link
Copy Markdown
Author

Thanks Josh, I'll address all the comments tomorrow!

Comment thread main.go Outdated
@baergj

baergj commented Oct 28, 2021

Copy link
Copy Markdown
Contributor

Addresses another aspect of #14.

Make a distinction when an operation is possible but no
backfill reservation is available vs no operation possible
@alram alram force-pushed the pgremapper-dirty-change branch from 19ba2ae to fc49e0a Compare October 28, 2021 17:11
@alram

alram commented Oct 28, 2021

Copy link
Copy Markdown
Author

updated. Quick tests:

# ./pgremapper undo-upmaps 4 --target
change possible but no backfill reservation available, try later.
# ./pgremapper undo-upmaps 0 --target
The following changes would be made to the upmap exception table:
pg 11.104: [0->3]
pg 11.107: [0->1]
pg 11.10b: [0->2]
No changes made - use --yes to apply changes.
# ./pgremapper undo-upmaps 0 4 --target
The following changes would be made to the upmap exception table:
pg 11.104: [0->3]
pg 11.107: [0->1]
pg 11.10b: [0->2]
No changes made - use --yes to apply changes.
# ./pgremapper undo-upmaps 4 0 --target
The following changes would be made to the upmap exception table:
pg 11.104: [0->3]
pg 11.107: [0->1]
pg 11.10b: [0->2]
No changes made - use --yes to apply changes.

@baergj baergj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alram alram merged commit d8a0709 into main Oct 28, 2021
@alram alram deleted the pgremapper-dirty-change branch October 28, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants