Upgrade xscgen, net6.0 and kaizen #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class IdentificationResult had a public constructor taking a string as parameter and internally performed mapping between the generated xml-domain and its own domain. This strange stringy contract made for tight coupling between the domains. This should be done in the transformation code DataTransferObjectConverter. Now with an internal constructor and two different ones makes for better separation of consern between what is an error and what is an identified person. With regards to IdentificationError.Unknown vs NotFound, I made this comment in the code: `Unknown` is never actually returned from Digipost. `NotFound` is. But since `Unknown` has been the de facto response for `NotFound` since for ever in this client library we should just keep it that way.
* Upgrade xscgen to the newest version ++ * move xml domain to a properly scoped namespace * Build with .net 6.x * Better scopeing in mapping code by allways useing V8 for generated types
hermanwh
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code-improve - Kaizen
Refactor IdentificationResult
The class IdentificationResult had a public constructor taking a string
as parameter and internally performed mapping between the generated
xml-domain and its own domain. This strange stringy contract made for
tight coupling between the domains. This should be done in the
transformation code DataTransferObjectConverter. Now with an internal
constructor and two different ones makes for better separation of consern
between what is an error and what is an identified person.
With regards to IdentificationError.Unknown vs NotFound, I made this comment in the code:
Unknownis never actually returned from Digipost.NotFoundis. But sinceUnknownhasbeen the de facto response for
NotFoundsince for ever in this client librarywe should just keep it that way.