feat Add css class "m-overlay__inner" #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TriangleJuice
approved these changes
Jan 6, 2025
NicolasYapla
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
This PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Wanneer een modal geopend wordt, heeft dit niet de functionaliteiten dat hem ooit had.
Zoals het verticaal scrollen.
Zichtbaar op https://digipolisantwerp.github.io/antwerp-ui_angular/modules/layout/modal wanneer men het browser heel klein maakt zodat scrolling nodig is.
Deze class is ooit verwijderd geweest uit de section. In mijn ogen was dit een kleine overzicht want dit bracht breaking changes die nooit opgelost zijn. Dit is ook een scss class dat specifiek hiervoor gemaakt is en nog steeds bestaat.
Verwijderd geweest in deze commit:
82c8a51#diff-3bf724efdd4d4f7fd818bbb1c3523f96f047b3dcb1c3c4c0a41cdbbfc63a98f7L8