change delimiter for appending url parameters in redirect if existing parameters are present#120
Merged
benoist merged 1 commit intodigidentity:masterfrom May 10, 2016
Conversation
Contributor
|
Looks good to me! Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the quick review and merge of my last PR 😄. Here is another small code change to get libsaml working with Google's IDP. When integrating with Google, the SSO url has an existing query parameter (https://accounts.google.com/o/saml2/idp?idpid=xxx), which causes an error due to the
SAMLRequestparameter being appended with a?instead of a&.This PR changes the redirect url creation to check for existing parameters, and append the SAML parameters with the correct delimiter.