Merged
Conversation
8eef22d to
de091d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #447
The following places have been updated as follows:
variantparam in the URL. Note that we DO NOT try to render other variants as fallbacks. We can consider doing that or redirecting to the relevant URLs if desired, but in most cases this won't be necessary since navigation links to this page are only available based on the presence of the relevant variant.For all of these, I've also improved the error handling so that there are clearer logs in Sentry. Before, we'd get reports about the image load error event from
SuspenseImage, which were not very informative e.g. title would be something likeAsyncContextStack.withScopeand message likeEvent (type=error) captured as exception. Now we provide a more semantic log e.g.Failed to load original imagealong with a payload about the attachment/blob that can be found in theAdditional Datasection on Sentry.