fix(toggle-group): re-introduce disabled on items#4618
Merged
Conversation
🦋 Changeset detectedLatest commit: 5a3e4c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Preview deployments for this pull request: storybook - |
2 tasks
Barsnes
approved these changes
Mar 13, 2026
Member
Barsnes
left a comment
Barsnes
left a comment
There was a problem hiding this comment.
seems fine to me. Could maybe add some comments in code, but I think this is good enough
mimarz
reviewed
Mar 13, 2026
mimarz
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #4581
the styling is now done via setting aria-disabled on the label (because it has
ds-buttonclass this works), but perhaps it can be done with a bit of:hasselector in.ds-toggle-groupinstead to avoid that extra dom-manipulation needed when used as raw web. But then again using disabled is not something we recommend in general so 🤷