fix(badge): ensure badge is above focus-ring#4511
Merged
Conversation
oddvernes
requested review from
Barsnes,
eirikbacker and
mimarz
as code owners
🦋 Changeset detectedLatest commit: dc3a3fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Preview deployments for this pull request: storybook - |
eirikbacker
reviewed
Feb 18, 2026
| <VideoIcon title='Skru på video' /> | ||
| </Badge.Position> | ||
| </Button> | ||
| <Badge.Position> |
Contributor
There was a problem hiding this comment.
nice
Want to check with @Febakke if we are to examplify this before I click ✅
https://designsystemet.slack.com/archives/C07K7NEKXEW/p1771434332924849?thread_ts=1771235016.569749&cid=C07K7NEKXEW
eirikbacker
reviewed
Feb 19, 2026
Barsnes
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #4503
modified storybook story with a new example to capture this in visual tests
since the grandparent (.ds-badge--position) has position: relative, the z-index should be scoped to that and won't poke through other potential floating elements on the page