ungate try_from because it has been stabilized #2010
Conversation
| platform: Linux | ||
| rust_version: nightly-2018-11-27 | ||
| # least nightly release that stabilize try_from | ||
| rust_version: nightly-2019-02-26 |
There was a problem hiding this comment.
Updated nightly version to pass test. Is this acceptable? To say more, what's the policy of supported nightly version?
There was a problem hiding this comment.
Yeah, that's fine. This is only the compile tests. We don't officially support nightly, we just bump this periodically as needed to be able to run the compile tests (which require nightly)
azure-pipelines.yml
Outdated
| parameters: | ||
| platform: Linux | ||
| rust_version: nightly-2018-11-27 | ||
| # least nightly release that stabilize try_from |
There was a problem hiding this comment.
I don't think we need this comment
| //! [gitter.im/diesel-rs/diesel](https://gitter.im/diesel-rs/diesel) | ||
| #![cfg_attr(feature = "unstable", feature(specialization, try_from))] | ||
| #![cfg_attr(feature = "unstable", feature(specialization))] |
There was a problem hiding this comment.
We should remove the gating on the uses of this feature as well (grep try_from)
There was a problem hiding this comment.
try_from has been stabilized (ungated) at nightly but it is still nightly only API.
There was a problem hiding this comment.
Can you update the FIXME comment to specify which Rust version we can use it?
weiznich
left a comment
weiznich
left a comment
There was a problem hiding this comment.
CI says the output of the compile tests changed. That needs to be fixed (Updating the expected output is ok as long as the error messages do not regress)
| @@ -1 +1 @@ | |||
| nightly-2018-11-27 | |||
| nightly-2019-02-26 | |||
There was a problem hiding this comment.
That changes the output of our compile tests, which means you need to go though that errors and adjust them. (There is a script for that)
This version supports `TryFrom` so remove that feature from our unstable list. Also fix all new clippy warnings and update the compile test output to newer compiler versions
3 participants
See also rust-lang/rust#58302.
This fixes failures of other CIs