Skip to content

Stats compatibility with A-Frame 1.8.0+ #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diarmidmackenzie wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Stats compatibility with A-Frame 1.8.0+ #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ba43d5
Include CSS that won't be in A-Frame from 1.8 onwards
diarmidmackenzie May 26, 2025
1d68d50
Make replacement CSS conditional on A-Frame version 1.8.0+
diarmidmackenzie May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion component-usage/stats-panel.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html>
<head>
<script src="https://aframe.io/releases/1.7.0/aframe.min.js"></script>
<script src="../components/stats-panel/index.js"></script>
<script src="../components/stats-panel/dist/stats-panel.js"></script>
<link rel="stylesheet" href="../styles.css">
<script>
AFRAME.registerComponent('generate-data', {
Expand Down
2 changes: 1 addition & 1 deletion components/stats-panel/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ The source of data for is always an event, with some properties in its `detail`
## Installation

```
<script src="https://cdn.jsdelivr.net/npm/aframe-stats-panel@0.2.2/index.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/aframe-stats-panel@0.2.2/dist/stats-panel.min.js"></script>
```

Or via [npm](https://www.npmjs.com/package/aframe-stats-panel)
Expand Down
707 changes: 707 additions & 0 deletions components/stats-panel/dist/stats-panel.js
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions components/stats-panel/dist/stats-panel.min.js
View file
Open in desktop

Large diffs are not rendered by default.

16 changes: 15 additions & 1 deletion components/stats-panel/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
const semver = require('semver');
function isAFrameVersionAtLeast(minVersion) {
if (!AFRAME || !AFRAME.version) {
console.warn('A-Frame not found or version not available');
return false;
}

return semver.gte(AFRAME.version, minVersion);
}

if (isAFrameVersionAtLeast('1.8.0')) {
require('./styles.css')
}

AFRAME.registerComponent('stats-panel', {
schema: {
merge: {type: 'boolean', default: true}
Expand Down Expand Up @@ -130,7 +144,7 @@ AFRAME.registerComponent('stats-row', {
this.data.properties.forEach((property) => {
const split = this.splitDot(property);
let value = e.detail;
for (i = 0; i < split.length; i++) {
for (let i = 0; i < split.length; i++) {
value = value[split[i]];
}
this.counterValues[property].innerHTML = value
Expand Down
Loading