Skip to content

fix: use unversioned api endpoint for tracker sub-resources #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mediremi merged 4 commits into from
Apr 6, 2022
Merged

fix: use unversioned api endpoint for tracker sub-resources #1158

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
89387cd
fix: use unversioned api endpoints for tracker sub-resources
jimiolaniyan Mar 31, 2022
cc3a734
fix: rename placeholder to be consistent
jimiolaniyan Mar 31, 2022
aec18a1
chore: format
mediremi Apr 5, 2022
a6a1df6
Merge branch 'master' into fix-tracker-endpoint
mediremi Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions services/data/src/links/RestAPILink/queryToResourcePath.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,15 @@ describe('queryToResourcePath', () => {
)
})

it('should return an unversioned endpoint sub-resources of the new tracker importer (in version 2.37)', () => {
const query: ResolvedResourceQuery = {
resource: 'tracker/test',
}
expect(queryToResourcePath(link, query, 'read')).toBe(
`${link.unversionedApiPath}/tracker/test`
)
})

it('should return a VERSIONED endpoint for the new tracker importer (in version 2.38)', () => {
const query: ResolvedResourceQuery = {
resource: 'tracker',
Expand Down
2 changes: 1 addition & 1 deletion services/data/src/links/RestAPILink/queryToResourcePath.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ const makeActionPath = (resource: string) =>
)

const skipApiVersion = (resource: string, config: Config): boolean => {
if (resource === 'tracker') {
if (resource === 'tracker' || resource.startsWith('tracker/')) {
if (!config.serverVersion?.minor || config.serverVersion?.minor < 38) {
return true
}
Expand Down