Feature / add alb support #1250
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurist38
reviewed
Aug 30, 2021
| requestContext: { | ||
| elb: { | ||
| targetGroupArn: | ||
| 'arn:aws:elasticloadbalancing:us-east-1:550213415212:targetgroup/5811b5d6aff964cd50efa8596604c4e0/b49d49c443aa999f', |
There was a problem hiding this comment.
It seems to me that this hardcoded value needs to be removed
Collaborator
There was a problem hiding this comment.
definitely, let's replace it with a dummy arn for target group
|
Hi guys! This PR looks promising and is actually quite needed for the community. Shall we proceed with it? |
pgrzesik
reviewed
Sep 6, 2021
| requestContext: { | ||
| elb: { | ||
| targetGroupArn: | ||
| 'arn:aws:elasticloadbalancing:us-east-1:550213415212:targetgroup/5811b5d6aff964cd50efa8596604c4e0/b49d49c443aa999f', |
Collaborator
There was a problem hiding this comment.
definitely, let's replace it with a dummy arn for target group
| process.exit(1) | ||
| } | ||
|
|
||
| // TODO move the following block |
Collaborator
There was a problem hiding this comment.
Is that supposed to be addressed in this PR?
|
Is there any progress on this? Otherwise I'm happy to take it on |
Owner
|
1 yo PR with conflicts, please feel free to reopen. |
Owner
|
This is the author coming back to maintain his repo, sorry for the harsh decision. |
Author
|
Unfortunately I don't have enough capacity and context at the moment. So don't wait for me please. |
ihendriks
added a commit
to ihendriks/serverless-offline
that referenced
this pull request
Aug 1, 2022
Based on: - dherault#1250 by bayoumymac - https://github.com/tmaslen/serverless-local-alb-example by tmaslen
ihendriks
added a commit
to ihendriks/serverless-offline
that referenced
this pull request
Aug 2, 2022
Based on: - dherault#1250 by bayoumymac - https://github.com/tmaslen/serverless-local-alb-example by tmaslen
ihendriks
added a commit
to ihendriks/serverless-offline
that referenced
this pull request
Aug 2, 2022
Based on: - dherault#1250 by bayoumymac - https://github.com/tmaslen/serverless-local-alb-example by tmaslen
ihendriks
added a commit
to ihendriks/serverless-offline
that referenced
this pull request
Aug 9, 2022
Based on: - dherault#1250 by bayoumymac - https://github.com/tmaslen/serverless-local-alb-example by tmaslen
ihendriks
added a commit
to ihendriks/serverless-offline
that referenced
this pull request
Aug 12, 2022
Based on: - dherault#1250 by bayoumymac - https://github.com/tmaslen/serverless-local-alb-example by tmaslen
ihendriks
added a commit
to ihendriks/serverless-offline
that referenced
this pull request
Nov 10, 2022
Based on: - dherault#1250 by bayoumymac - https://github.com/tmaslen/serverless-local-alb-example by tmaslen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently aws ALB received support for lambdas as a target group, there are some advantages for using ALBs instead of apigw, a quick google search will show multiple articles about the topic
Motivation and Context
closes #598
with many people using alb events for lambdas, it will be really helpful to have alb emulation
How Has This Been Tested?
Screenshots (if appropriate):