True bytes #42
Merged
True bytes #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy non-controversial part of #36 Credit: Paul Dicker <[email protected]>
Includes both the values output now and the values which should be output by #36.
Owner
Author
|
@pitdicker pretty sure this should be okay but I'll let you have a look before I merge |
|
Great! I was just trying to find motivation to write such tests ;-). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically prep for #36.
I was surprised by the quite significant ChaCha bug, but less so by the other one. Probably both would have been fixed by #36 anyway.
Byte sequences generated with code like this (using values from previous tests as source):
https://play.rust-lang.org/?gist=473b9d5a304322f64b2d110f2c7c3521&version=nightly