Closed
Conversation
keboliu
approved these changes
Nov 30, 2022
dgsudharsan
pushed a commit
that referenced
this pull request
Mar 14, 2023
…cause file removal issue (sonic-host-services #46) (sonic-net#14106) Why I did it Porting/cherry-pick PR sonic-net/sonic-host-services#46 "show reboot-cause history" shows empty history. When the previous-reboot-cause has a broken symlink, And rebooting the system will not be able to generate a new symlink of the new previous-reboot-cause. admin@sonic:~$ show reboot-cause history Name Cause Time User Comment ------ ------- ------ ------ --------- How I did it Somehow, when the symlink file /host/reboot-cause/previous-reboot-cause is broken (which its destination files doesn't exist in this case), the current condition check "if os.path,exists(PREVIOUS_REBOOT_CAUSE_FILE)" will return False in determine-reboot-cause script. Hence, the current previous-reboot-cause is not been removed and the recreation of the new previous-reboot-cause failed. In case of previous-reboot-cause is a broken synlink file, add condition os.path.islink(PREVIOUS_REBOOT_CAUSE) to check and allow the remove operation happens. How to verify it Manually make the /host/reboot-cause/previous-reboot-cause to be a broken symlink file by removing its destination file reboot the system. "show reboot-cause history" should show the correct info Signed-off-by: mlok <marty.lok@nokia.com>
dgsudharsan
pushed a commit
that referenced
this pull request
Feb 22, 2024
…ly (sonic-net#18046) #### Why I did it src/dhcprelay ``` * 363fa06 - (HEAD -> master, origin/master, origin/HEAD) Skip vlans with no dhcpv6 server configured (#46) (8 hours ago) [kellyyeh] ``` #### How I did it #### How to verify it #### Description for the changelog
dgsudharsan
pushed a commit
that referenced
this pull request
Feb 20, 2025
…ly (sonic-net#21743) #### Why I did it src/sonic-stp ``` * 29eb387 - (HEAD -> master, origin/master, origin/HEAD) Fixing compilaion error for marvell_armhf (#47) (9 hours ago) [Divya Kumaran Chandralekha] * b7da558 - Merge pull request #44 from wajahatrazi/stp_co_pr (3 days ago) [Divya Kumaran Chandralekha] |\ | failure_prs.log skip_prs.log 47e1e77 - Merge branch 'master' into stp_co_pr (3 days ago) [Divya Kumaran Chandralekha] | |\ | |/ |/| * | 6e4a94f - Merge pull request #46 from divyachandralekha/pvst_pr_1 (4 days ago) [Divya Kumaran Chandralekha] |\ \ | failure_prs.log skip_prs.log | aa5e824 - libevent explicit building dependency removed (4 days ago) [Divya Chandralekha] |/ / * | 9345e5a - Merge pull request #43 from omaaartamer/fix/alignment-warnings (5 days ago) [Divya Kumaran Chandralekha] * | eedb772 - [stp] Add memory alignment padding to structures (9 weeks ago) [omaaartamer] * | 128e53d - fix: resolve STP alignment warnings (9 weeks ago) [omaaartamer] / * 30febfa - Fixing changes in the code (9 weeks ago) [Wajahat Razi] ``` #### How I did it #### How to verify it #### Description for the changelog
dgsudharsan
pushed a commit
that referenced
this pull request
Mar 17, 2025
…lly (sonic-net#731) #### Why I did it src/sonic-swss ``` * b87da49 - (HEAD -> 202412, origin/202412) Set Port UPDATE_DSCP attribute when TC_TO_DSCP map is attached (#44) (9 hours ago) [mssonicbld] * 8c99374 - sonic-swss: Code changes for WRED and ECN statistics (#46) (9 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
dgsudharsan
pushed a commit
that referenced
this pull request
Mar 17, 2025
… automatically (sonic-net#768) #### Why I did it src/sonic-platform-common ``` * 44faed9 - (HEAD -> 202412, origin/202412) [code sync] Merge code from sonic-net/sonic-platform-common:202411 to 202412 (#46) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
dgsudharsan
pushed a commit
that referenced
this pull request
May 12, 2025
…D automatically (sonic-net#1025) #### Why I did it src/sonic-sairedis ``` * 08c1e34 - (HEAD -> 202412, origin/HEAD, origin/202412) Merge pull request #46 from r12f/user/riffjiang/fix-merge (31 minutes ago) [Riff] * a49942e - Revert "Merge pull request #45 from r12f/code-sync-202412" (38 minutes ago) [r12f] ``` #### How I did it #### How to verify it #### Description for the changelog
dgsudharsan
pushed a commit
that referenced
this pull request
Aug 20, 2025
…sonic-net#23654) #### Why I did it src/dhcpmon ``` * 1cb6ced - (HEAD -> master, origin/master, origin/HEAD) Update clear_counter_timeout to fix clear counter issue (#45) (19 hours ago) [Yaqiang Zhu] * 848304e - [build] Update to use libyang3 (#46) (4 days ago) [Yaqiang Zhu] ``` #### How I did it #### How to verify it #### Description for the changelog
dgsudharsan
pushed a commit
that referenced
this pull request
Dec 16, 2025
… HEAD automatically (sonic-net#1375) #### Why I did it src/sonic-linux-kernel ``` * 7f3e021 - (HEAD -> 202412, origin/HEAD, origin/202412) Integrate HW-MGMT 7.0040.4019 Changes (#46) (6 hours ago) [Vivek] ``` #### How I did it #### How to verify it #### Description for the changelog
dgsudharsan
pushed a commit
that referenced
this pull request
Jan 15, 2026
…tically (sonic-net#23416) #### Why I did it src/sonic-dash-api ``` * aa3fc48 - (HEAD -> master, origin/master, origin/HEAD) [ci] Automated agent pool migration for branch master (#46) (3 days ago) [yijingyan2] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Fixed sflow yang model to include collector_vrf field.
How I did it
Added leaf for collector_vrf under sflow_collector.
How to verify it
Added UT to verify.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)