Closed
Conversation
Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>
dgsudharsan
changed the title
| } | ||
|
|
||
|
|
||
| typedef policer_packet_action { |
There was a problem hiding this comment.
Wonder why it is called "policer_packet_action". This enum derives from sai_packet_action_t and can be reused accross different modules, not just policer. I suggest calling it just "packet_action".
EDIT: I see that in the implementation inside orchagent, copporch and policerorch packet_action_map are two different maps, thus I suggest to leave copp_packet_action and add policer_packet_action with same content to reflect that. Otherwise adding a new action to packet_action_map inside copporch would require automatic support of this action from policerorch when adding it here, which might not be supported.
Ideally, copporch should be reusing the implementation of policerorch and then it could be a single typedef of policer_packet_action but I don't see that is how it works.
Owner
Author
There was a problem hiding this comment.
@stepanblyschak Currently both policerorch and copporch support the same actions. IMO the code is duplicate (which should be cleaned up) and I don't see a scenario where an action supported in copp orch will not be supported in policerorch or vice versa. In fact in both examples we just map the value to SAI attribute and invoke create policer. Since copp uses policer I feel it's better not to duplicate it at yang level.
Comment on lines
+1
to
+5
| {% if yang_model_type == "cvl" %} | ||
| /* this is sonic cvl yang model */ | ||
| {% else %} | ||
| /* this is sonic py yang model */ | ||
| {% endif %} |
There was a problem hiding this comment.
What is the purpose to be a jinja template and have these comments?
Owner
Author
There was a problem hiding this comment.
The j2 template was introduced recently. The main purpose is to support both config management class (py yang) which DPB and other sonic applications use as well as sonic-mgmt framework (cvl).
Currently this is just used for comments but in the future we could add more j2 checks. So It is better to define it as j2 instead of json.
stepanblyschak
approved these changes
Feb 8, 2022
dgsudharsan
pushed a commit
that referenced
this pull request
Mar 8, 2022
ce72b0d Longxiang Lyu Thu Feb 24 06:05:12 2022 Put handler member functions as virtual in base (#30) ef59e4f Jing Zhang Fri Feb 25 11:38:28 2022 Incrementing tolerance on mux state inconsistency (#27) 2d12892 Longxiang Lyu Wed Feb 16 03:32:06 2022 Rename LinkManagerStateMachine to ActiveStandbyStateMachine (#26) f38634c Jing Zhang Thu Feb 17 17:23:56 2022 Update log level for mux probing and mux state chance (#23) a8434dd Jing Zhang Thu Feb 17 17:21:01 2022 Handle xcvrd crashing scenarios (#22) 2ebdb2b Longxiang Lyu Mon Feb 14 13:26:07 2022 [make] Enable make extra includes (#24)
dgsudharsan
pushed a commit
that referenced
this pull request
Mar 23, 2022
Changes: Update submodule branch to 202012 [sonic-linkmgrd][202012] submodule update a8ddff5 Jing Zhang Fri Feb 25 11:38:28 2022 Incrementing tolerance on mux state inconsistency (#27) a3f78a3 Jing Zhang Thu Feb 17 17:23:56 2022 Update log level for mux probing and mux state chance (#23) 05156fb Jing Zhang Thu Feb 17 17:21:01 2022 Handle xcvrd crashing scenarios (#22) 74529ef Longxiang Lyu Mon Feb 14 13:26:07 2022 [make] Enable make extra includes (#24) sign-off: Jing Zhang zhangjing@microsoft.com
dgsudharsan
pushed a commit
that referenced
this pull request
Jun 7, 2022
[sonic-linkmgrd][master] Submodule Update 9c8a16e Jing Zhang Sun Jun 5 08:27:07 2022 -0700 Separate I2C mux state probing and gRPC forwarding state probing (#86) 491c4ee Longxiang Lyu Sun Jun 5 23:26:19 2022 +0800 Fix peer mux wait back off factor (#84) a0b6b14 Jing Zhang Wed Jun 1 10:33:12 2022 -0700 Revert "Update log level for mux probing and mux state chance (#23)" (#85) 3c2b546 Jing Zhang Tue May 31 10:14:42 2022 -0700 Add default route support to active-active state machine (#78) 6fa892e Longxiang Lyu Fri May 27 09:15:06 2022 +0800 Degrade LinkProberStateMachineBase virtual function logging level (#80) 7b695ca Longxiang Lyu Fri May 27 09:14:02 2022 +0800 Fix mux wait timer and peer mux wait timer (#81)
dgsudharsan
pushed a commit
that referenced
this pull request
Jun 30, 2022
[sonic-linkmgrd][202012] submodule update 0839af2 Longxiang Lyu Wed Jun 15 08:46:21 2022 +0800 [202012] Fix IP header checksum in handleSendSwitchCommand (#89) afc4972 Jing Zhang Wed Jun 1 10:33:12 2022 -0700 Revert "Update log level for mux probing and mux state chance (#23)" (#85) ed52d0a Longxiang Lyu Tue May 31 10:28:30 2022 +0800 Add a command line option to store logs into a separate file (#83) sign-off: Jing Zhang zhangjing@microsoft.com
dgsudharsan
pushed a commit
that referenced
this pull request
Jul 6, 2022
linkmgrd: * d27ca81 2022-06-05 | Separate I2C mux state probing and gRPC forwarding state probing (#86) (HEAD -> 202205) [Jing Zhang] * 9d7d301 2022-06-01 | Revert "Update log level for mux probing and mux state chance (#23)" (#85) [Jing Zhang] * 60d3d77 2022-06-05 | Fix peer mux wait back off factor (#84) [Longxiang Lyu] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
dgsudharsan
pushed a commit
that referenced
this pull request
Oct 7, 2024
…tically (sonic-net#19465) src/sonic-dash-api * 43d9f7c - (HEAD -> 202311, origin/202311) [build]Update pool sonicbld to sonic-ububtu-1c since it's deprecated (#23) (23 hours ago) [Jianquan Ye]
dgsudharsan
pushed a commit
that referenced
this pull request
Mar 17, 2025
…tically (sonic-net#713) #### Why I did it src/sonic-sairedis ``` * 9fbe10d - (HEAD -> 202412, origin/HEAD, origin/202412) [code sync] Merge code from sonic-net/sonic-sairedis:202411 to 202412 (#23) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
dgsudharsan
pushed a commit
that referenced
this pull request
Mar 17, 2025
…tomatically (sonic-net#746) #### Why I did it src/sonic-linux-kernel ``` * ef476a4 - (HEAD -> 202412, origin/HEAD, origin/202412) [code sync] Merge code from sonic-net/sonic-linux-kernel:202411 to 202412 (#23) (26 seconds ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
dgsudharsan
pushed a commit
that referenced
this pull request
Mar 17, 2025
…omatically (sonic-net#762) #### Why I did it src/sonic-swss-common ``` * df8df20 - (HEAD -> 202412, origin/HEAD, origin/202412) [FC] remove FLEX_COUNTER_DELAY_STATUS_FIELD (sonic-net#982) (#23) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
dgsudharsan
pushed a commit
that referenced
this pull request
May 31, 2025
…UT so that we can get back to back Paladin ports up with Arista-7060X6-16PE-384C-O128S2 (sonic-net#1144) <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it Currently when we loaded HWSKU `Arista-7060X6-16PE-384C-O128S2` on two moby devices and connect their Paladin ports back to back, we can't get link up. It may help if we can get these links up and run the tests. ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it Created a new `FANOUT` HWSKU containing special lanemap and polarity configs so that we can load `Arista-7060X6-16PE-384C-O128S2` on one Moby and `Arista-7060X6-16PE-384C-O128S2-FANOUT` and get Paladin ports up when connecting them back to back with the following setup: ``` Moby1 Moby2 HWSKU: Arista-7060X6-16PE-384C-O128S2 HWSKU: Arista-7060X6-16PE-384C-O128S2-FANOUT #17 <-> #18 #19 <-> #20 #21 <-> #22 #23 <-> #24 #18 <-> #17 #20 <-> #19 #22 <-> #21 #24 <-> #23 ``` #### How to verify it Verified that all the Paladin ports can link up with the above setup. <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 - [ ] 202211 - [ ] 202305 - [x] msft-202412 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> - [x] msft-202412 #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> Created `Arista-7060X6-16PE-384C-O128S2-FANOUT` based on `Arista-7060X6-16PE-384C-O128S2` and only update lanemap and polarity settings in bcm config. <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
dgsudharsan
pushed a commit
that referenced
this pull request
Sep 25, 2025
…t back to back Paladin ports up with Arista-7060X6-16PE-384C-O128S2 (sonic-net#22719) <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it Currently when we loaded HWSKU `Arista-7060X6-16PE-384C-O128S2` on two moby devices and connect their Paladin ports back to back, we can't get link up. It may help if we can get these links up and run the tests. ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it Created a new `FANOUT` HWSKU containing special lanemap and polarity configs so that we can load `Arista-7060X6-16PE-384C-O128S2` on one Moby and `Arista-7060X6-16PE-384C-O128S2-FANOUT` and get Paladin ports up when connecting them back to back with the following setup: ``` Moby1 Moby2 HWSKU: Arista-7060X6-16PE-384C-O128S2 HWSKU: Arista-7060X6-16PE-384C-O128S2-FANOUT #17 <-> #18 #19 <-> #20 #21 <-> #22 #23 <-> #24 #18 <-> #17 #20 <-> #19 #22 <-> #21 #24 <-> #23 ``` #### How to verify it Verified that all the Paladin ports can link up with the above setup. <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 - [ ] 202211 - [ ] 202305 - [x] msft-202412 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> - [x] msft-202412 #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> Created `Arista-7060X6-16PE-384C-O128S2-FANOUT` based on `Arista-7060X6-16PE-384C-O128S2` and only update lanemap and polarity settings in bcm config. <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sudharsan Dhamal Gopalarathnam sudharsand@nvidia.com
Why I did it
Added yang model for policer table
How I did it
Creating yang model for policer
How to verify it
Added unit tests to verify the change.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)