[Mellanox]Extending the ipinip json check to cover new Nvidia platforms#118
Closed
dgsudharsan wants to merge 1 commit intomasterfrom
Closed
[Mellanox]Extending the ipinip json check to cover new Nvidia platforms#118dgsudharsan wants to merge 1 commit intomasterfrom
dgsudharsan wants to merge 1 commit intomasterfrom
Conversation
oleksandrivantsiv
approved these changes
Mar 8, 2025
dgsudharsan
pushed a commit
that referenced
this pull request
Jan 15, 2026
…ically (sonic-net#24435) #### Why I did it src/sonic-dash-ha ``` * 149774b - (HEAD -> master, origin/master, origin/HEAD) Add a PR template (#129) (3 days ago) [yue-fred-gao] * 711a0be - Sort the output of show actor command (#128) (3 days ago) [yue-fred-gao] * 15fbd5c - Fix format for protobuf fields in show command. (#127) (3 days ago) [dypet] * f2d47b9 - Add wait for loopback script. (#126) (3 days ago) [dypet] * 570db05 - Fix issue #118: use hostname to build service path (#122) (3 days ago) [yue-fred-gao] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
The existing check compares "mlnx" string to apply specific ecn mode. However newer platforms contain "nvidia" in platform string. So extending this check to cover newer platforms as well.
Work item tracking
How I did it
Extending the check in j2 files to include nvidia platforms
How to verify it
Running regression tests.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)