Fix python3.12 build failure#79
Merged
awvwgk merged 5 commits intodftd3:mainfrom Sep 2, 2024
wangenau:main
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 48.63% 50.24% +1.60%
==========================================
Files 34 24 -10
Lines 3707 2448 -1259
Branches 1518 987 -531
==========================================
- Hits 1803 1230 -573
+ Misses 1207 877 -330
+ Partials 697 341 -356 ☔ View full report in Codecov by Sentry. |
awvwgk
reviewed
Sep 2, 2024
awvwgk
approved these changes
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #62.
setuptoolsis now a required build dependency for Python 3.12, see https://cffi.readthedocs.io/en/stable/whatsnew.html#v1-16-0.It wasn't super clear to me how the wheels that land on PyPI are generated. To test this I downloaded the current source distribution, modified the
pyproject.tomlfile, and tested that the installation works.Someone needs to make sure that this also works with your workflow/in the CI.
The same patch should be applicable to dftd4 and tblite.
Linked issues for reference: tblite/tblite#195 tblite/tblite#198
While at it, I have also updated the usage of random calls to replace some deprecated function calls.
I will have no access to the internet for the next two weeks and probably won't reply on this PR, sorry for that.