Merged
Conversation
Signed-off-by: Federico Pedron <fedekbe@gmail.com>
awvwgk
reviewed
Aug 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
==========================================
+ Coverage 48.63% 50.24% +1.60%
==========================================
Files 34 24 -10
Lines 3707 2448 -1259
Branches 1518 987 -531
==========================================
- Hits 1803 1230 -573
+ Misses 1207 877 -330
+ Partials 697 341 -356 ☔ View full report in Codecov by Sentry. |
awvwgk
approved these changes
Aug 12, 2024
Member
awvwgk
left a comment
awvwgk
left a comment
There was a problem hiding this comment.
Thanks for sharing. Looks good to me.
awvwgk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the workarounds for Cray compilers mentioned in #76.
Closes #76.