Skip to content
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions assets-minimal.nix

This file was deleted.

11 changes: 6 additions & 5 deletions assets.nix
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
{ pkgs ? import ./nix {}
, agent-js ? import ./src/agent/javascript { inherit pkgs; }
, bootstrap-js ? import ./src/bootstrap { inherit pkgs agent-js; }
, assets-minimal ? import ./assets-minimal.nix { inherit pkgs; }
, distributed-canisters ? import ./distributed-canisters.nix { inherit pkgs assets-minimal; }
, distributed-canisters ? import ./distributed-canisters.nix { inherit pkgs; }
}:
pkgs.runCommandNoCCLocal "assets" {} ''
mkdir -p $out

cp -R ${assets-minimal}/* $out

cp ${pkgs.dfinity.ic-replica}/bin/replica $out
cp ${pkgs.dfinity.ic-starter}/bin/ic-starter $out
cp ${pkgs.motoko.mo-ide}/bin/mo-ide $out
cp -R ${pkgs.motoko.base-src} $out/base
cp ${pkgs.motoko.didc}/bin/didc $out
cp ${pkgs.motoko.mo-doc}/bin/mo-doc $out
cp ${pkgs.motoko.mo-ide}/bin/mo-ide $out
cp ${pkgs.motoko.moc-bin}/bin/moc $out
cp ${pkgs.motoko.rts}/rts/mo-rts.wasm $out

# Install agent
mkdir $out/js-user-library
Expand Down
7 changes: 2 additions & 5 deletions default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,9 @@ rec {

cargo-audit = import ./cargo-audit.nix { inherit pkgs; };

assets = import ./assets.nix { inherit pkgs agent-js assets-minimal bootstrap-js distributed-canisters; };
assets-minimal = import ./assets-minimal.nix { inherit pkgs; };
assets = import ./assets.nix { inherit pkgs agent-js bootstrap-js distributed-canisters; };

dfx-minimal = import ./dfx-minimal.nix { inherit pkgs assets-minimal; };

distributed-canisters = import ./distributed-canisters.nix { inherit pkgs assets-minimal dfx-minimal; };
distributed-canisters = import ./distributed-canisters.nix { inherit pkgs; };

inherit (pkgs) nix-fmt nix-fmt-check;

Expand Down
29 changes: 0 additions & 29 deletions dfx-minimal.nix

This file was deleted.

53 changes: 23 additions & 30 deletions distributed-canisters.nix
Original file line number Diff line number Diff line change
@@ -1,39 +1,32 @@
{ pkgs ? import ./nix {}
, assets-minimal ? import ./assets-minimal.nix { inherit pkgs; }
, dfx-minimal ? import ./dfx-minimal.nix { inherit pkgs assets-minimal; }
}:
let
distributed = lib.noNixFiles (lib.gitOnlySource ./. ./src/distributed);
lib = pkgs.lib;

workspace = pkgs.runCommandNoCC "distributed-canisters-workspace" {} ''
# We want $HOME/.cache to be in a writable temporary directory.
export HOME=$(mktemp -d -t dfx-distributed-canisters-home-XXXX)
mkdir -p $out
for source_root in ${distributed}/*; do
canister_name=$(basename $source_root)
build_dir=$out/$canister_name
mkdir -p $build_dir
cp -R $source_root/* $build_dir
( cd $build_dir ; DFX_ASSETS=${assets-minimal} ${dfx-minimal}/bin/dfx build --check )
done
'';

in
pkgs.runCommandNoCCLocal "distributed-canisters" {} ''
for canister_root in ${workspace}/*; do
canister_name=$(basename $canister_root)
output_dir=$out/$canister_name
mkdir -p $output_dir
for ext in did wasm
do
cp $canister_root/.dfx/local/canisters/$canister_name/$canister_name.$ext $output_dir
done
pkgs.runCommandNoCCLocal "distributed-canisters" {
inherit (pkgs.motoko) didc rts;
moc = pkgs.motoko.moc-bin;
base = pkgs.motoko.base-src;
} ''
mkdir -p $out
for canister_mo in ${distributed}/*.mo; do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that we currently have a single Motoko file in distributed. Is this directory expected to grow quite a bit? If so it's probably more efficient to have multiple derivations that build a single Motoko file instead of a single derivation that builds multiple Motoko files.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, but it does make sense that if we had more than a few of these, it could be better to use a parameterized derivation.

canister_name=$(basename -s .mo $canister_mo)
build_dir=$out/$canister_name
mkdir -p $build_dir
$moc/bin/moc \
$canister_mo \
-o $build_dir/$canister_name.did \
--idl \
--package base $base
MOC_RTS=$rts/rts/mo-rts.wasm $moc/bin/moc \
$canister_mo \
-o $build_dir/$canister_name.wasm \
-c --release \
--package base $base
done
''
20 changes: 0 additions & 20 deletions src/distributed/assetstorage/dfx.json

This file was deleted.