fix(IDX): sync Prometheus scraping targets with NNS registry#9297
Open
pietrodimarco-dfinity wants to merge 2 commits intomasterfrom
Open
fix(IDX): sync Prometheus scraping targets with NNS registry#9297pietrodimarco-dfinity wants to merge 2 commits intomasterfrom
pietrodimarco-dfinity wants to merge 2 commits intomasterfrom
Conversation
The metrics_sync_task periodically generates Prometheus scraping target files from the local registry store, but this store was never re-synced with the NNS after initial setup. When new subnets/nodes were added via ic-admin, the local store remained stale and Prometheus never discovered the new targets. Sync the local registry with the NNS before taking the topology snapshot so that dynamically added subnets and nodes appear in Grafana. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sync_with_prometheusbefore generating Prometheus scraping targets