Skip to content

fix: candid spec to support setting multiple custom HTTP headers on asset creation #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smallstepman merged 1 commit into from
Jul 12, 2022
Merged

fix: candid spec to support setting multiple custom HTTP headers on asset creation #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/ic-certified-assets/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.2.4] - 2022-07-12
### Fixed
- headers field in Candid spec accepts mmultiple HTTP headers
Copy link
Contributor

@viviveevee viviveevee Jul 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- headers field in Candid spec accepts mmultiple HTTP headers
- headers field in Candid spec accepts multiple HTTP headers


## [0.2.3] - 2022-07-06
### Added
- Support for setting custom HTTP headers on asset creation
Expand Down
2 changes: 1 addition & 1 deletion src/ic-certified-assets/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "ic-certified-assets"
version = "0.2.3"
version = "0.2.4"
edition = "2021"
authors = ["DFINITY Stiftung <[email protected]>"]
description = "Rust support for asset certification."
Expand Down
2 changes: 1 addition & 1 deletion src/ic-certified-assets/assets.did
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ type CreateAssetArguments = record {
key: Key;
content_type: text;
max_age: opt nat64;
headers: opt HeaderField;
headers: opt vec HeaderField;
};

// Add or change content for an asset, by content encoding
Expand Down