EES-6692: Add checklist warning when data upload missing association with API data set#6712
Merged
tomjonesdev merged 9 commits intodevfrom Feb 6, 2026
Merged
EES-6692: Add checklist warning when data upload missing association with API data set#6712tomjonesdev merged 9 commits intodevfrom
tomjonesdev merged 9 commits intodevfrom
Conversation
mmoalin
reviewed
Feb 5, 2026
src/GovUk.Education.ExploreEducationStatistics.Admin/Services/ReleasePublishingValidator.cs
Show resolved
Hide resolved
mmoalin
reviewed
Feb 5, 2026
Contributor
mmoalin
left a comment
There was a problem hiding this comment.
Good approach, I haven't tested this nor been had any immediate thoughts pop up for the scenario that you mentioned which is to do with published releases, I just had some minor comments though.
src/GovUk.Education.ExploreEducationStatistics.Admin/Services/Public.Data/DataSetService.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Admin/Services/ReleasePublishingValidator.cs
Outdated
Show resolved
Hide resolved
...Education.ExploreEducationStatistics.Admin.Tests/Services/ReleasePublishingValidatorTests.cs
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Admin/Services/Public.Data/DataSetService.cs
Show resolved
Hide resolved
...Education.ExploreEducationStatistics.Admin.Tests/Services/ReleasePublishingValidatorTests.cs
Show resolved
Hide resolved
mmoalin
requested changes
Feb 5, 2026
mmoalin
reviewed
Feb 5, 2026
src/GovUk.Education.ExploreEducationStatistics.Admin/Services/ReleasePublishingValidator.cs
Show resolved
Hide resolved
added 8 commits
February 6, 2026 10:07
… loop, handle null draft versions.
…ring release versions.
mmoalin
reviewed
Feb 6, 2026
...cation.ExploreEducationStatistics.Admin.Tests/MockBuilders/DataSetSummaryViewModelBuilder.cs
Outdated
Show resolved
Hide resolved
…ultiple data sets.
mmoalin
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds a warning message when a user has uploaded a data file when the publication has an API data set, but has not created a new version of said data set using that uploaded file.
The show/don't show logic covers a few cases; the publication has an API data set, and:
The logic misses this case:
This PR also includes a class to separate checklist validation out to a service so that individual rules can be more easily tested. This has the added benefit of reducing the complexity of the checklist service, and I think moving the other methods out might be useful (suggest raising a new task if you agree).
I also added a checklist test for unresolved comments as this must have been missed from previous work.