Skip to content

Update prerun_utils.R#149

Open
seankgibson wants to merge 1 commit intomainfrom
correction_to_daily_totals
Open

Update prerun_utils.R#149
seankgibson wants to merge 1 commit intomainfrom
correction_to_daily_totals

Conversation

@seankgibson
Copy link
Contributor

Pull request overview

Two corrections to daily totals

Pull request checklist

Please check if your PR fulfils the following:

  • [ x] Tests for the changes have been added (for bug fixes / features)
  • [ x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • [ x] Tests have been run locally and are passing (run_tests_locally())
  • [ x] Code is styled according to tidyverse styling (checked locally with tidy_code())

What is the current behaviour?

Generation of NA values in dashboard output.

  • Week commencing not included in group by and therefore empty on bind.
  • Total not added to school type and therefore empty on bind

What is the new behaviour?

NA values no longer created

Anything else

Add any notes for people reviewing and testing your code that are appropriate. Tag a @person to review if someone in particular needs to see this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments