in serviceMonitor add metricRelabelings & relabelings, fix labels #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: smartbit <[email protected]>
Signed-off-by: smartbit <[email protected]>
Signed-off-by: smartbit <[email protected]>
sagikazarmark
requested changes
Apr 6, 2022
Member
sagikazarmark
left a comment
sagikazarmark
left a comment
There was a problem hiding this comment.
Please update the change log and run make docs.
More details in the contribution guide.
| type: application | ||
| name: dex | ||
| version: 0.8.0 | ||
| version: 0.8.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fix & enhance serviceMonitor
What this PR does / why we need it
in serviceMonitor
metricRelabelings:and in comments add sample to be able to recognize the metricsrelabelings:for those who want themSpecial notes for your reviewer
Updated Chart to v0.8.2, please push the appropriate version to https://charts.dexidp.io
Checklist
Chart.yaml(see the contributing guide for details)Chart.yaml(see the contributing guide for details)make docs