feat(charts/dex): add extraObjects #132
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TheRealNoob <[email protected]>
Signed-off-by: TheRealNoob <[email protected]>
TheRealNoob
force-pushed
the
add_extraobjects
branch
from
55d0288 to
5b34082
Compare
TheRealNoob
changed the title
Signed-off-by: TheRealNoob <[email protected]>
3 tasks
Author
|
@nabokihms Could I bother you for a review please? There is another PR #143 open aiming to do the same thing - one should be merged the other closed. |
|
I've added this functionality to a bunch of our charts in my organisation. I'm +1 in favour of allowing extraObjects to be inputted as a dict, as it allows for merging across multiple values files |
|
@TheRealNoob You'll need to add a sign off to acknowledge the DCO. |
Signed-off-by: TheRealNoob <[email protected]>
Signed-off-by: TheRealNoob <[email protected]>
Helm complains when coasescing objects of two different types, such as from the default list to map Signed-off-by: TheRealNoob <[email protected]> Signed-off-by: TheRealNoob <[email protected]>
TheRealNoob
force-pushed
the
add_extraobjects
branch
from
6ad5603 to
e900b47
Compare
Signed-off-by: TheRealNoob <[email protected]>
Author
|
@cardoe ready for re-review |
Signed-off-by: TheRealNoob <[email protected]>
Author
|
bumped the chart patch version when i should have bumped the minor version. fixed. |
Signed-off-by: TheRealNoob <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What this PR does / why we need it
Closes #23 #130 dexidp/dex#3227
add
extraObjectsobject, allowing people to define their own (set of) custom manifestsSpecial notes for your reviewer
Checklist
Chart.yaml(see the contributing guide for details)Chart.yaml(see the contributing guide for details)make docs