Skip to content

Conversation

@kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Oct 13, 2025

Description

Fixes https://github.com/devtron-labs/sprint-tasks/issues/2600

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Summary by Bito

This pull request significantly enhances the security of database credentials by implementing encryption for sensitive fields such as passwords and access tokens across various components. Key changes include the addition of a securestore dependency and updates to multiple files to ensure sensitive information is securely handled and stored. Overall, this update aims to prevent exposure of sensitive data and improve the application's security posture.

@github-actions
Copy link

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@github-actions
Copy link

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

vikramdevtron
vikramdevtron previously approved these changes Oct 13, 2025
@bito-code-review
Copy link

Bito Review Skipped - No Changes Detected

Bito didn't review this pull request because we did not detect any changes in the pull request to review.

@kartik-579 kartik-579 merged commit fcac4ff into main Oct 13, 2025
8 checks passed
@kartik-579 kartik-579 deleted the pwd-db-encryption branch October 13, 2025 07:25
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@bito-code-review
Copy link

Bito Review Skipped - No Changes Detected

Bito didn't review this pull request because we did not detect any changes in the pull request to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants