Skip to content

Conversation

@SATYAsasini
Copy link
Contributor

@SATYAsasini SATYAsasini commented Aug 28, 2025

Description

Fixes https://github.com/devtron-labs/sprint-tasks/issues/2519

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Summary by Bito

This pull request enhances API responses by improving error messages and handling across various endpoints. Key modifications include more descriptive error messages for invalid parameters and improved logging for better debugging, aiming to provide clearer feedback for users and developers.

@github-actions
Copy link

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@gitguardian
Copy link

gitguardian bot commented Aug 28, 2025

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
19465121 Triggered Generic High Entropy Secret 15b2a4f scripts/sql/34304100_bulk_edit_config.up.sql View secret
20477209 Triggered Generic High Entropy Secret 40bb962 tests/api-spec-validation/Makefile View secret
19602448 Triggered Generic High Entropy Secret 4338a20 tests/api-spec-validation/Makefile View secret
19601641 Triggered AWS IAM Keys 67387e6 tests/api-spec-validation/reports/live-server-validation-report.md View secret
19578172 Triggered Generic High Entropy Secret b35c605 tests/api-spec-validation/Makefile View secret
19601642 Triggered GitHub Fine Grained Personal Access Token 67387e6 tests/api-spec-validation/reports/live-server-validation-report.md View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@github-actions
Copy link

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@sonarqubecloud
Copy link

@prkhrkat prkhrkat merged commit c017ed0 into develop Sep 1, 2025
10 checks passed
@prkhrkat prkhrkat deleted the fix-api-responses branch September 1, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants