Skip to content

fix: app clone panic #6696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged

fix: app clone panic #6696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/appClone/AppCloneService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ import (
bean3 "github.com/devtron-labs/devtron/pkg/pipeline/bean"
globalUtil "github.com/devtron-labs/devtron/util"
"github.com/go-pg/pg"
"github.com/pkg/errors"
"go.uber.org/zap"
"net/http"
"strings"
Expand Down Expand Up @@ -767,6 +768,9 @@ func (impl *AppCloneServiceImpl) createWfInstances(refWfMappings []bean4.AppWork
impl.logger.Errorw("error in creating ci pipeline, app clone", "err", err)
return createWorkflowMappingDto, err
}
if ci == nil || ci.CiPipelines == nil || len(ci.CiPipelines) == 0 {
return createWorkflowMappingDto, errors.New("ci pipeline not created")
}
impl.logger.Debugw("ci created", "ci", ci)
}

Expand Down Expand Up @@ -812,6 +816,7 @@ type cloneCiPipelineRequest struct {
func (impl *AppCloneServiceImpl) CreateCiPipeline(req *cloneCiPipelineRequest) (*bean.CiConfigRequest, error) {
refCiConfig, err := impl.pipelineBuilder.GetCiPipeline(req.refAppId)
if err != nil {
impl.logger.Errorw("error in fetching ci config", "err", err)
return nil, err
}

Expand All @@ -825,6 +830,7 @@ func (impl *AppCloneServiceImpl) CreateCiPipeline(req *cloneCiPipelineRequest) (
}
}
if refCiPipeline == nil {
impl.logger.Errorw("error in fetching ci pipeline", "err", err)
return nil, nil
}
pipelineName := refCiPipeline.Name
Expand Down