feat: Audit ci trigger, precd and post cd trigger so that retrigger can happen from last failed config snapshot #6659
Conversation
prakash100198
requested review from
nishant-d,
prakarsh-dt,
vikramdevtron and
vivek-devtron
as code owners
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 2763127 | Triggered | Generic High Entropy Secret | d5ef9b2 | scripts/devtron-reference-helm-charts/cronjob-chart_1-6-0/secrets-test-values.yaml | View secret |
| 141558 | Triggered | Generic High Entropy Secret | d5ef9b2 | scripts/devtron-reference-helm-charts/gpu-workload-4-21-0/env-values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
# Conflicts: # env_gen.json
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
pkg/workflow/trigger/audit/service/WorkflowTriggerAuditService.go
Outdated
Show resolved
Hide resolved
pkg/workflow/trigger/audit/service/WorkflowTriggerAuditService.go
Outdated
Show resolved
Hide resolved
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
prakash100198
changed the title
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
|
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
Description
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2054
Checklist:
Does this PR introduce a user-facing change?