sync: Release candidate v0.37.0 #6645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix upgrade feedback issue * Refactor installer module path handling for configurability. Replaced hardcoded installer module paths with configurable environment variables in `ServerEnvConfig`. This improves flexibility and maintainability, allowing paths to be customized without altering the codebase. Removed redundant constant `INSTALLER_MODULES_HELM_KEY`. * Refactor module key generation to use basePath configuration. Updated functions to include `basePath` in module enable key generation, ensuring consistency and flexibility when constructing keys. Adjusted related calls across services to pass the `basePath` from environment configuration. * Update env_gen.json placeholder content Revised the content of env_gen.json to modify the placeholder or default configuration. This ensures alignment with the expected environment setup and eliminates any outdated references. * Refactor server status mapping logic for Helm applications Simplified and standardized the server status mapping by reinstating Helm release-based logic, removing redundant code, and eliminating the `mapApplicationStatusToServerStatus` function. This enhances maintainability and aligns with existing Helm release workflows. * installation sleep * Fix syntax error in installation script sleep function Replaced incorrect usage of `sleep(180);` with `sleep 180` to align with proper syntax. This ensures the installation script runs without errors during execution. * Fix syntax for sleep function in installation script Replaced incorrect usage of `sleep` with the proper function call `sleep(180)`. This ensures the script executes correctly without syntax errors. * Update installation script to replace sleep with shellScript Replaced the fixed sleep duration with repeated shellScript calls to improve the script's flexibility and manageability. This change aims to enhance the installation process by providing clearer execution control and better * Update installation script to replace sleep with shellScript Replaced the fixed sleep duration with repeated shellScript calls to improve the script's flexibility and manageability. This change aims to enhance the installation process by providing clearer
* notification for failed Deployment * notification for failed Deployment IN ARGO * review comments * async func * fix * wire
sync: Develop main sync
* external argo fixes * removing unwanted param * nil handling * updating rest config --------- Co-authored-by: Asutosh Das <[email protected]>
fix: panic in async execution flow
* fixed user status function inauthroser * fix: correct function name for user retrieval in UserService
kartik-579
requested review from
nishant-d,
pawan-mehta-dt,
prakarsh-dt,
tayalrishabh96,
vikramdevtron and
vivek-devtron
as code owners
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9257608 | Triggered | Base64 AWS keys | 000bd42 | scripts/devtron-reference-helm-charts/deployment-chart_4-21-0/test-values.json | View secret |
| 2763127 | Triggered | Generic High Entropy Secret | 000bd42 | scripts/devtron-reference-helm-charts/deployment-chart_4-21-0/secrets-test-values.yaml | View secret |
| 141558 | Triggered | Generic High Entropy Secret | 000bd42 | scripts/devtron-reference-helm-charts/reference-chart_5-1-0/env-values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
vivek-devtron
previously approved these changes
Jun 4, 2025
…main-sync-4jun-2 sync: Release candidate v0.37.0 main sync
vivek-devtron
approved these changes
Jun 4, 2025
nishant-d
approved these changes
Jun 4, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Checklist:
Does this PR introduce a user-facing change?