Skip to content

fix: reverted telemetry connection error #6587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025
Merged

fix: reverted telemetry connection error #6587

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e51243
reverted telemetry connection error
prkhrkat May 20, 2025
25b7912
reverted telemetry connection error
prkhrkat May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion client/telemetry/TelemetryEventClient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"context"
"encoding/base64"
"encoding/json"
"errors"
"fmt"
cloudProviderIdentifier "github.com/devtron-labs/common-lib/cloud-provider-identifier"
posthogTelemetry "github.com/devtron-labs/common-lib/telemetry"
Expand Down Expand Up @@ -690,8 +691,13 @@ func (impl *TelemetryEventClientImpl) checkForOptOut(ctx context.Context, UCID s
if err != nil {
// this should be non-blocking call and should not fail the request for ucid getting
impl.logger.Errorw("check opt-out list failed, rest api error", "ucid", UCID, "err", err)
return false, err
}
flag, ok := response["result"].(bool)
if !ok {
impl.logger.Errorw("check opt-out list failed, type assertion error", "ucid", UCID)
return false, errors.New("type assertion error")
}
flag := response["result"].(bool)
return flag, nil
}

Expand Down
Loading