Skip to content

fix: error pg.ErrNoRow on base deployment template update #6533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged

fix: error pg.ErrNoRow on base deployment template update #6533

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3e3adc
fix: error pg.ErrNoRow on base deployment template update
Ash-exp Apr 24, 2025
489c992
fix: reordered updateChartLocationForEnvironmentConfigs func
Ash-exp Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions pkg/chart/ChartService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,12 +663,6 @@ func (impl *ChartServiceImpl) UpdateAppOverride(ctx context.Context, templateReq
return nil, err
}

err = impl.updateChartLocationForEnvironmentConfigs(newCtx, templateRequest.AppId, templateRequest.ChartRefId, templateRequest.UserId, template.ChartVersion)
if err != nil {
impl.logger.Errorw("error in updating chart location in env overrides", "appId", templateRequest.AppId, "err", err)
return nil, err
}

} else {
return nil, nil
}
Expand Down Expand Up @@ -725,6 +719,14 @@ func (impl *ChartServiceImpl) UpdateAppOverride(ctx context.Context, templateReq
return nil, err
}

if currentLatestChart.Id != 0 && currentLatestChart.Id != templateRequest.Id {
err = impl.updateChartLocationForEnvironmentConfigs(newCtx, templateRequest.AppId, templateRequest.ChartRefId, templateRequest.UserId, template.ChartVersion)
if err != nil {
impl.logger.Errorw("error in updating chart location in env overrides", "appId", templateRequest.AppId, "err", err)
return nil, err
}
}

appLevelMetricsUpdateReq := &bean.DeployedAppMetricsRequest{
EnableMetrics: templateRequest.IsAppMetricsEnabled,
AppId: templateRequest.AppId,
Expand Down
Loading