chore: code restructuring #6476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ash-exp
requested review from
nishant-d,
prakarsh-dt,
vikramdevtron and
vivek-devtron
as code owners
|
The migration files have successfully passed the criteria!! |
4 similar comments
|
The migration files have successfully passed the criteria!! |
|
The migration files have successfully passed the criteria!! |
|
The migration files have successfully passed the criteria!! |
|
The migration files have successfully passed the criteria!! |
|
The migration files have successfully passed the criteria!! |
|
The migration files have successfully passed the criteria!! |
kartik-579
requested changes
Mar 27, 2025
api/restHandler/app/pipeline/configure/DeploymentPipelineRestHandler.go
Outdated
Show resolved
Hide resolved
api/restHandler/app/pipeline/configure/DeploymentPipelineRestHandler.go
Outdated
Show resolved
Hide resolved
api/restHandler/app/pipeline/configure/DeploymentPipelineRestHandler.go
Outdated
Show resolved
Hide resolved
api/restHandler/app/pipeline/configure/DeploymentPipelineRestHandler.go
Outdated
Show resolved
Hide resolved
internal/sql/repository/chartConfig/PipelineConfigRepository.go
Outdated
Show resolved
Hide resolved
pkg/deployment/manifest/deploymentTemplate/chartRef/ChartRefService.go
Outdated
Show resolved
Hide resolved
|
The migration files have successfully passed the criteria!! |
kartik-579
requested changes
Mar 31, 2025
api/restHandler/app/pipeline/configure/DeploymentPipelineRestHandler.go
Outdated
Show resolved
Hide resolved
pkg/deployment/manifest/deploymentTemplate/chartRef/ChartRefService.go
Outdated
Show resolved
Hide resolved
|
kartik-579
approved these changes
Apr 3, 2025
vikramdevtron
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2031
Checklist:
Does this PR introduce a user-facing change?