feat: oss ent refactoring #6414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shivam-nagar23
requested review from
nishant-d,
prakarsh-dt,
vikramdevtron and
vivek-devtron
as code owners
nishant-d
suggested changes
Feb 24, 2025
pkg/auth/user/RoleGroupService.go
Outdated
| clusterRoleFieldDto := adapter.BuildClusterRoleFieldsDto(entity, accessType, roleFilter.Cluster, namespace, group, kind, resource, actionType, subaction) | ||
| roleModel, err := impl.userAuthRepository.GetRoleByFilterForAllTypes(clusterRoleFieldDto) | ||
| if err != nil { | ||
| impl.logger.Errorw("error in getting new role model by filter") |
pkg/auth/user/UserCommonService.go
Outdated
| if roleModel.Id == 0 { | ||
| impl.logger.Warnw("no role found for given filter", "filter", roleFilter) | ||
| impl.logger.Debugw("no role found for given filter", "filter", roleFilter) | ||
| userInfo.Status = "role not fount for any given filter: " + roleFilter.Team + "," + environment + "," + entityName + "," + roleFilter.Action |
There was a problem hiding this comment.
check if we can remove it
| } | ||
| if !operationDone { | ||
| //loading policy for safety | ||
| casbin2.LoadPolicy() |
There was a problem hiding this comment.
check if user specific reload is possible
pkg/auth/user/UserService.go
Outdated
| UpdatedOn: time.Now(), | ||
| }} | ||
| userRoleModel, err = impl.userAuthRepository.CreateUserRoleMapping(userRoleModel, tx) | ||
| impl.logger.Infow("Creating Polices for cluster", resource, kind, namespace, group) |
| switch entity { | ||
| case bean2.CLUSTER_ENTITIY: | ||
| { | ||
| cluster, namespace, group, kind, resource, action := roleFieldDto.Cluster, roleFieldDto.Namespace, roleFieldDto.Group, roleFieldDto.Kind, roleFieldDto.Resource, roleFieldDto.Action |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Checklist:
Does this PR introduce a user-facing change?