Skip to content

fix: auto pre-cd not getting triggered (if cd is manual) after webhook ci event is captured #6407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

fix: auto pre-cd not getting triggered (if cd is manual) after webhook ci event is captured #6407

merged 1 commit into from
Feb 20, 2025

Conversation

@prakash100198
Copy link
Contributor

@prakash100198 prakash100198 commented Feb 20, 2025 •
edited
Loading

Description

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1941

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@prakash100198 prakash100198 changed the title IsCdQualifiedForAutoTriggerForWebhookCiEvent fix: auto pre-cd not getting triggered (if cd is manual) after webhook ci event is captured Feb 20, 2025
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@prakash100198 prakash100198 merged commit e67c3b7 into main Feb 20, 2025
12 of 13 checks passed
@prakash100198 prakash100198 deleted the webhook-manual-cd-fix branch February 20, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

@vivek-devtron vivek-devtron Awaiting requested review from vivek-devtron vivek-devtron is a code owner

1 more reviewer

@nishant-d nishant-d nishant-d approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR:Ready-to-Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prakash100198 @nishant-d