chore: Argocd dependabot fixes #6402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamayushm
requested review from
nishant-d,
prakarsh-dt,
vikramdevtron and
vivek-devtron
as code owners
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 15200081 | Triggered | PGP Private Key | fa3a305 | vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.go | View secret |
| 15200082 | Triggered | PGP Private Key | fa3a305 | vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.go | View secret |
| 7214865 | Triggered | PGP Private Key | fa3a305 | vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.go | View secret |
| 15200083 | Triggered | PGP Private Key | fa3a305 | vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.go | View secret |
| 15200084 | Triggered | PGP Private Key | fa3a305 | vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
iamayushm
added a commit
that referenced
this pull request
Mar 7, 2025
* wip:deployment config old data migration code * updating repo url get usage * comments * adding comments * wip: adding repo name in deployment config struct * migration files * migration update * feat: updated the target revision * review changes * nil handling * dev testing bug fixes * fixes * value file name fix * fixes * repo url function update * git repo url handing using code * fixing import cycle * feat: dynamic chart loaction and valuesfile path * CRUD operations * repo clone and env override create flow * wip: self review changes * feat: trigger flows updated * self review changes * refactoring * self review fix: env override create * skipping checks * feat: Skip GitOps config CRUD ACD operation if argo module is not installed * handling for IsGitOpsConfigured * feat: release mode data adaptor * validation api * deployment status changes and application filter logic change * self review changes * delete acd app handling * adding route * modifying validate link request * pipeline crud operation * dev testing fix * wip: release config data type fix * fixing check * updated wire gen * added api /environment-variables * added releaseMode validation * fix: isGitOpsEnable flag * updated EnvironmentVariableList response * updated git repo validations * updated migration number * fix: skip pipeline create validation * panic handler for cd pipeline creation * updated wire dep * fix: cd trigger panic fix * fix: validation migrate cd pipeline api * updated ValidateGitOpsRepoUrl request for custom gitops logic * fix: git clone logic for validate migration request * fix: updated API key * chart name handling for migrate release * fix: chart validation * fix: chart validation * fix: pipeline creation * feat: is gitops repo configured flag updated * wip: trigger fix * feat: filter external argo app list * read service for circular import * fix nil poniter panic * fix: empty argo app list * fix empty app name * updated dep of DeploymentConfigService instead of DeploymentConfigReadService in ArgoApplicationService * minor refactorings * replaced release app name from util function * validation and flag if config is for external helm release * fix migrated from flag * fix: resource tree api with scoop * fix: error handling for GetResourceTree * fixing set chart location function * updating config type * fix: scoop argo_cd GetResourceTree * fix: updated validation error * fix: updated BuildDeployedAppName references * fix: common wire set * updating chart location while delete * fix user id * common function for url already present * removing duplicate logic for pipeline filter * fix: nil checker issues * updated global api * pg no rows handling * manual sync mode fix for trigger/deployment statys * fix: resource tree * fix: panic handling * fix default namespace * wip * fix: pipeline delete flow * fix: delete apllication object * fix: delete application object * chore: refactored AppDetailsReadService * added: vlaidation for link external release * review comment incorporated * fix: pointer datatype * added: EnforcedPolicyViolation validation * fix app clone * make fix * fix: workflow_execution_stage cloumn * added gitops adapter * helm deployment status fix * updated deployment config queries * fix: generate manifest diff * wire gen updated * updated feature flag name * updated env_gen.md file * feat: argocd resource tree support * fix: nil handling updated * fix: context handling * review changes * chore: deployment config refactorings * fix: on-board argocd issues * updated updateArgoAppDeleteStatus func * review changes * make fix * delete argo app error handling fixes * payload changes * argo app listing api updated * updated wire_gen files * chore: Argocd dependabot fixes (#6402) * version matched with enterprise * vulnerability fix * argocd dependabot fixes * argo workflow dependabot fixes * fix: link request * updated migration script * fix: GetDeploymentConfigMinForAppAndEnv for app stage api * fix: helm app gitops target revision * fix: cd pipeline create blocked if argo module not installed * setting repo url in new deployment config also * default branch (backward compatibility) if branch is not passed * updated target revision * fix: release config target revision * updated not deployed status to degraded * go mod tidy * fix: app delete flow * fix: git commit ref not found * fix: git commit ref not found * fix: gitops branch pull error * fix enum * fix: removed unused import * chore: func renamed * updating chart location when base version is changed * chart location update in deployment config * chart env override fix * wip: fixed pg no rows * wip: bug fixes * fix empty cluster url * namespace fix * listing api fix * wip: installed app query fix * fix for argo module not installed * wip: adding chart loaction * renaming * wip: head validation * deployment app type change fix * chart location heal * wip: validation for linked pipeline in app change api * fix deployment change api * migration update * migration file rename --------- Co-authored-by: Ash-exp <[email protected]>
iamayushm
added a commit
that referenced
this pull request
Mar 19, 2025
* wip:deployment config old data migration code * updating repo url get usage * comments * adding comments * wip: adding repo name in deployment config struct * migration files * migration update * feat: updated the target revision * review changes * nil handling * dev testing bug fixes * fixes * value file name fix * fixes * repo url function update * git repo url handing using code * fixing import cycle * feat: dynamic chart loaction and valuesfile path * CRUD operations * repo clone and env override create flow * wip: self review changes * feat: trigger flows updated * self review changes * refactoring * self review fix: env override create * skipping checks * feat: Skip GitOps config CRUD ACD operation if argo module is not installed * handling for IsGitOpsConfigured * feat: release mode data adaptor * validation api * deployment status changes and application filter logic change * self review changes * delete acd app handling * adding route * modifying validate link request * pipeline crud operation * dev testing fix * wip: release config data type fix * fixing check * updated wire gen * added api /environment-variables * added releaseMode validation * fix: isGitOpsEnable flag * updated EnvironmentVariableList response * updated git repo validations * updated migration number * fix: skip pipeline create validation * panic handler for cd pipeline creation * updated wire dep * fix: cd trigger panic fix * fix: validation migrate cd pipeline api * updated ValidateGitOpsRepoUrl request for custom gitops logic * fix: git clone logic for validate migration request * fix: updated API key * chart name handling for migrate release * fix: chart validation * fix: chart validation * fix: pipeline creation * feat: is gitops repo configured flag updated * wip: trigger fix * feat: filter external argo app list * read service for circular import * fix nil poniter panic * fix: empty argo app list * fix empty app name * updated dep of DeploymentConfigService instead of DeploymentConfigReadService in ArgoApplicationService * minor refactorings * replaced release app name from util function * validation and flag if config is for external helm release * fix migrated from flag * fix: resource tree api with scoop * fix: error handling for GetResourceTree * fixing set chart location function * updating config type * fix: scoop argo_cd GetResourceTree * fix: updated validation error * fix: updated BuildDeployedAppName references * fix: common wire set * updating chart location while delete * fix user id * common function for url already present * removing duplicate logic for pipeline filter * fix: nil checker issues * updated global api * pg no rows handling * manual sync mode fix for trigger/deployment statys * fix: resource tree * fix: panic handling * fix default namespace * wip * fix: pipeline delete flow * fix: delete apllication object * fix: delete application object * chore: refactored AppDetailsReadService * added: vlaidation for link external release * review comment incorporated * fix: pointer datatype * added: EnforcedPolicyViolation validation * fix app clone * make fix * fix: workflow_execution_stage cloumn * added gitops adapter * helm deployment status fix * updated deployment config queries * fix: generate manifest diff * wire gen updated * updated feature flag name * updated env_gen.md file * feat: argocd resource tree support * fix: nil handling updated * fix: context handling * review changes * chore: deployment config refactorings * fix: on-board argocd issues * updated updateArgoAppDeleteStatus func * review changes * make fix * delete argo app error handling fixes * payload changes * argo app listing api updated * updated wire_gen files * chore: Argocd dependabot fixes (#6402) * version matched with enterprise * vulnerability fix * argocd dependabot fixes * argo workflow dependabot fixes * fix: link request * updated migration script * fix: GetDeploymentConfigMinForAppAndEnv for app stage api * fix: helm app gitops target revision * fix: cd pipeline create blocked if argo module not installed * setting repo url in new deployment config also * default branch (backward compatibility) if branch is not passed * updated target revision * fix: release config target revision * updated not deployed status to degraded * go mod tidy * helm list api moved from enterprise * fix: app delete flow * listing api * query fix * fix: git commit ref not found * fix: git commit ref not found * fix: gitops branch pull error * validate api for external helm release * fix enum * fix: removed unused import * chore: func renamed * rest handler update * updating chart location when base version is changed * chart location update in deployment config * chart env override fix * wip: fixed pg no rows * wip: bug fixes * fix empty env id * integration fixes * is linkable true * fix chart name * enterprise code moved * function rename * fix empty cluster url * namespace fix * listing api fix * wip: installed app query fix * fix for argo module not installed * wip: adding chart loaction * renaming * wip * wip: head validation * refactoring * deployment app type change fix * chart location heal * wip: validation for linked pipeline in app change api * fix deployment change api * review changes * migration update * validation in create api * fixing issues * fix argo unsupported spec error parsingg * zero time handling * revert time parse * empty createdAt handling * fixing messaging around gitOps * removing hard coding * wip: deployment app name added * fix cluster nil pointer * fix panic if values file is empty * renaming --------- Co-authored-by: Ash-exp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Checklist:
Does this PR introduce a user-facing change?