Skip to content

Conversation

@prakash100198
Copy link
Contributor

Description

Fix for while cloning app or workflow when external secret is present in any pipeline then that pipeline is not cloned with error (both esoSecretData.esoDataFrom and esoSecretData.esoData can't be empty)

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1897

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@github-actions
Copy link

github-actions bot commented Feb 7, 2025

The migration files have successfully passed the criteria!!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2025

@prakash100198 prakash100198 merged commit 9e9856f into develop Feb 7, 2025
6 checks passed
@prakash100198 prakash100198 deleted the eso-secret-clone-fix branch February 7, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants