Skip to content

fix: sql injection fixes #6334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 29, 2025
Merged

fix: sql injection fixes #6334

merged 3 commits into from
Jan 29, 2025

Conversation

@kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Jan 29, 2025 •
edited
Loading

Description

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1642

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

nishant-d
nishant-d previously approved these changes Jan 29, 2025
View reviewed changes
@kartik-579 kartik-579 changed the base branch from main to develop January 29, 2025 04:57
@kartik-579 kartik-579 dismissed nishant-d’s stale review January 29, 2025 04:57

The base branch was changed.

@github-actions
Copy link

The migration files have successfully passed the criteria!!

@github-actions
Copy link

The migration files have successfully passed the criteria!!

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kartik-579 kartik-579 changed the title chore: sql injection fixes fix: sql injection fixes Jan 29, 2025
@github-actions
Copy link

The migration files have successfully passed the criteria!!

1 similar comment
@github-actions
Copy link

The migration files have successfully passed the criteria!!

@kartik-579 kartik-579 merged commit eb125b9 into develop Jan 29, 2025
10 checks passed
@kartik-579 kartik-579 deleted the sql-injection-fix-2 branch January 29, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

@vivek-devtron vivek-devtron Awaiting requested review from vivek-devtron vivek-devtron is a code owner

1 more reviewer

@nishant-d nishant-d nishant-d approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR:Ready-to-Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kartik-579 @nishant-d