Skip to content

Conversation

@prkhrkat
Copy link
Contributor

Description

Fixes #

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@gitguardian
Copy link

gitguardian bot commented Jan 17, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14998970 Triggered Generic Password d19e788 client/argocdServer/repoCredsK8sClient/repoCreds.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@prkhrkat prkhrkat changed the title createDownwardAPIVolume feat: Tag propagate in CI and Pre-Post CD Jan 17, 2025
nishant-d
nishant-d previously approved these changes Jan 17, 2025
@prkhrkat prkhrkat changed the title feat: Tag propagate in CI and Pre-Post CD misc: Tag propagate in CI and Pre-Post CD Jan 27, 2025
@github-actions
Copy link

The migration files have successfully passed the criteria!!

@sonarqubecloud
Copy link

@prkhrkat prkhrkat merged commit b77e05d into develop Jan 27, 2025
7 of 8 checks passed
@prkhrkat prkhrkat deleted the mandatory-tag-v2 branch January 27, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants