Skip to content

fix: user permissions not merging on same environments #6167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 12, 2024
Merged

fix: user permissions not merging on same environments #6167

merged 3 commits into from
Dec 12, 2024

Conversation

@Shivam-nagar23
Copy link
Member

@Shivam-nagar23 Shivam-nagar23 commented Dec 10, 2024 •
edited
Loading

Description

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1461

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

prkhrkat
prkhrkat reviewed Dec 10, 2024
View reviewed changes
prkhrkat
prkhrkat reviewed Dec 10, 2024
View reviewed changes
nishant-d
nishant-d suggested changes Dec 10, 2024
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
19.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Shivam-nagar23 Shivam-nagar23 merged commit b37bf8d into main Dec 12, 2024
9 of 11 checks passed
@Shivam-nagar23 Shivam-nagar23 deleted the fix-get-user-fix branch December 12, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prkhrkat prkhrkat prkhrkat left review comments

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

@vivek-devtron vivek-devtron Awaiting requested review from vivek-devtron vivek-devtron is a code owner

+1 more reviewer

@nishant-d nishant-d nishant-d approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR:Ready-to-Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Shivam-nagar23 @prkhrkat @nishant-d