Skip to content

fix: all modules installation fix #6140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2024
Merged

fix: all modules installation fix #6140

merged 1 commit into from
Nov 29, 2024

Conversation

@Shivam-nagar23
Copy link
Member

@Shivam-nagar23 Shivam-nagar23 commented Nov 29, 2024 •
edited
Loading

Description

Fixes #5160

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Shivam-nagar23 Shivam-nagar23 linked an issue Nov 29, 2024 that may be closed by this pull request
Bug: Stack Manager shows some modules (Build & Deploy, GitOps, Notifications, Monitoring) as installed when installing Devtron without any integrations #5160
Closed
2 tasks
@Shivam-nagar23 Shivam-nagar23 merged commit d37649f into main Nov 29, 2024
11 of 14 checks passed
@Shivam-nagar23 Shivam-nagar23 deleted the modeule-installation-fix branch November 29, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@nishant-d nishant-d Awaiting requested review from nishant-d

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

@vivek-devtron vivek-devtron Awaiting requested review from vivek-devtron vivek-devtron is a code owner

Assignees

No one assigned

Labels

PR:Ready-to-Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Stack Manager shows some modules (Build & Deploy, GitOps, Notifications, Monitoring) as installed when installing Devtron without any integrations

3 participants

@Shivam-nagar23 @vikramdevtron