misc: Update pr-issue-validator.yaml

.github/workflows/pr-issue-validator.yaml

@@ -172,75 +172,92 @@ jobs:
 
         # Fetch the latest changes from the main branch
         git fetch origin main
-
+        
         # Get the list of changed files
         git diff origin/main...HEAD --name-only > diff
-
+
+        # Specify the directory containing migration files
+        MIGRATION_DIR="scripts/sql"
+
+        # Print changed files
         echo "Changed files:"
         cat diff
-
-        echo "Changed SQL files-:"
-        # Filter SQL files from the list of changed files
-        awk '/scripts\/sql\//' diff
-
-        # Count the number of changed SQL files in the 'scripts/sql' directory
-        count=$(awk '/scripts\/sql\//' diff | wc -l)
-
-        # Check if no SQL files were changed
-        if [[ $count == "0" ]]; then 
-          echo "No SQL files were added, Exiting from this action."
+
+        # Extract relevant .up.sql migration files from the changed files list
+        changed_files=$(grep "^$MIGRATION_DIR/" diff | grep -E "\.up\.sql$")
+
+        # Check if there are any .up.sql migration files in the changed files list
+        if [ -z "$changed_files" ]; then
+          echo "No .up.sql migration files found in the changes."
           exit 0
         fi
-
-        # Iterate through each changed SQL file
-        for filename in $(awk '/scripts\/sql\//' diff); do
-          echo "Checking File: $filename"
-
-          # Check if the SQL file name is in the correct format (i.e., it ends with either '.up.sql' or '.down.sql')
-          if [[ "$filename" =~ \.(up|down)\.sql$ ]]; then
-
-            # Print a message that the file name is in the correct format
-            echo "File name: $filename is in the correct format"
-          else
-            # Print an error message
-            echo "Error: The SQL file name is not in the correct format: $filename."
-
-            # Post a comment on a GitHub pull request with the error message
-            gh pr comment $pr_no --body "The SQL file name: $filename is not in the correct format."
-
-            # Exit the script with a non-zero status code
-            exit 1 
+
+
+        # Extract unique migration numbers from the directory (considering only .up.sql files)
+        existing_migrations=$(ls $MIGRATION_DIR | grep -E "\.up\.sql$" | grep -oE "[0-9]{3}[0-9]{3}[0-9]{2}" | sort | uniq)
+
+        # Exclude migration numbers from changed files in existing_migrations
+        while read -r file; do
+          migration_number=$(basename "$file" | grep -oE "[0-9]{3}[0-9]{3}[0-9]{2}")
+          existing_migrations=$(echo "$existing_migrations" | grep -v "$migration_number")
+        done <<< "$changed_files"
+
+        # Validate each changed .up.sql migration file
+        is_valid=true
+        processed_migrations=()
+        while read -r file; do
+          # Extract migration number from the filename
+          migration_number=$(basename "$file" | grep -oE "[0-9]{3}[0-9]{3}[0-9]{2}")
+
+          # Check if the filename has the full XXXPPPNN format
+          if [[ ! $(basename "$file") =~ ^[0-9]{3}[0-9]{3}[0-9]{2}_ ]]; then
+            echo "Error: Migration file $file does not have the complete XXXPPPNN format."
+            is_valid=false
+            continue
           fi
-
-          # Navigate to the SQL files directory
-          sql_dir="scripts/sql"
-          echo "Current directory: $(pwd)"
-          cd "$sql_dir"
-          echo "SQL files directory: $(pwd)"
-
-          # Extract the migration number from the SQL file name
-          migration_no=$(echo "$filename" | cut -d "/" -f 3 | cut -d "_" -f 1)
-          echo "Migration Number: $migration_no"
-
-          # Count the number of files with the same migration number
-          migration_files_present_of_this_no=$(ls | cut -d "_" -f 1 | grep -w -c "$migration_no")
-
-          # Navigate back to the original directory
-          cd ../..
-
-          # Check the conditions based on the number of files with the same migration number
-          if [[ $migration_files_present_of_this_no == "2" ]]; then
-            echo "All looks good for this migration number."
-          elif [[ $migration_files_present_of_this_no == "1" ]]; then
-            # Only one file is present for this migration number
-            echo "Only single migration file was present for migration no.: $migration_no. either up or down migration is missing! EXITING"
-            gh pr comment $pr_no --body "Error: Only a single migration file was present for this number: $migration_no."
-            exit 1
-          else 
-            # Migration number is repeated
-            echo "Error: Migration number is repeated."
-            gh pr comment $pr_no --body "Error: The SQL file number: $migration_no is duplicated"
-            exit 1
+
+          if [ -z "$migration_number" ]; then
+            echo "Warning: Could not extract migration number from $file."
+            continue
           fi
-        done
-
+
+          # Check if this migration number has already been processed
+          if [[ " ${processed_migrations[@]} " =~ " $migration_number " ]]; then
+            continue
+          fi
+          processed_migrations+=("$migration_number")
+
+          # Check if the migration number is unique
+          if echo "$existing_migrations" | grep -q "$migration_number"; then
+            echo "Error: Migration number $migration_number already exists."
+            is_valid=false
+          fi
+
+          # Check if the migration number is greater than previous ones
+          last_migration=$(echo "$existing_migrations" | tail -n 1)
+          if [ "$migration_number" -le "$last_migration" ]; then
+            echo "Error: Migration number $migration_number is not greater than the latest ($last_migration)."
+            is_valid=false
+          fi
+
+          # Check for sequential hotfix requirement (if NN > 01, check for NN-1)
+          hotfix_number=$(echo "$migration_number" | grep -oE "[0-9]{2}$")
+          if [ "$hotfix_number" -gt "01" ]; then
+            previous_hotfix=$(printf "%02d" $((10#$hotfix_number - 1)))
+            expected_previous_number="${migration_number:0:6}$previous_hotfix"
+            if ! echo "$existing_migrations" | grep -q "$expected_previous_number"; then
+              echo "Error: Previous hotfix migration $expected_previous_number not found for $migration_number."
+              is_valid=false
+            fi
+          fi
+
+        done <<< "$changed_files"
+
+        if [ "$is_valid" = false ]; then
+          echo "Validation failed. Please fix the errors before merging."
+          gh pr comment $pr_no --body "The Migration files providede inside of the PR does not pass the criteria!!"
+          exit 1
+        fi
+
+        echo "All .up.sql migration file validations passed."
+        gh pr comment $pr_no --body "The migration files have successfully passed the criteria!!"