fix: app update migration #5903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamayushm
requested review from
kripanshdevtron,
nishant-d,
prakarsh-dt and
vikramdevtron
as code owners
nishant-d
suggested changes
Sep 25, 2024
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 10220829 | Triggered | Generic High Entropy Secret | 771423f | charts/devtron/devtron-bom.yaml | View secret |
| 10220829 | Triggered | Generic High Entropy Secret | 771423f | charts/devtron/values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
vikramdevtron
approved these changes
Sep 26, 2024
nishant-d
approved these changes
Sep 26, 2024
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
iamayushm
added a commit
that referenced
this pull request
Sep 27, 2024
* wip: adding app name check * wip * wip * wip * moving migration to code * wip: adding app name in log * wip: moving sql logic to code * pg no rows handling * adding db migration call * fixing fetch app query * wip: adding pg multiple rows handling * audit log update
vikramdevtron
pushed a commit
that referenced
this pull request
Sep 27, 2024
* oci registry delete issue * chaning error message * wip * fix ci pipeline trigger permission * fix external app link * fix: app update migration (#5903) * wip: adding app name check * wip * wip * wip * moving migration to code * wip: adding app name in log * wip: moving sql logic to code * pg no rows handling * adding db migration call * fixing fetch app query * wip: adding pg multiple rows handling * audit log update * cherry pick app update operation * dep vendor duiring build --------- Co-authored-by: nishant <[email protected]>
iamayushm
added a commit
that referenced
this pull request
Oct 3, 2024
* removing fetchArtifacts V1 usage and abstracting tag extraction logic * docker tag and repo method in util * modifying image tag logic in release override * wip: adding empty path check * review changes * fix: app update migration (#5903) * wip: adding app name check * wip * wip * wip * moving migration to code * wip: adding app name in log * wip: moving sql logic to code * pg no rows handling * adding db migration call * fixing fetch app query * wip: adding pg multiple rows handling * audit log update * fix: nil ptr fix in copying extraEnvVars * feat: Docker lint plugin (#5694) * added up script for docker linit plugin * rename of script file * docker lint down script * changes in docker lint * hadolint image * change in name of plugin * changes in down script * chnages in docker lint * chnages in down script * change in hadolint image * rename down script file * renaming sql script * feat: Added Devtron CI Trigger v1.1.0 (#5934) * Create 028901_019_devtron_ci_trigger_v1_1.down.sql * Create 028901_019_devtron_ci_trigger_v1_1.up.sql * Update 028901_019_devtron_ci_trigger_v1_1.up.sql --------- Co-authored-by: Prakarsh <[email protected]> * renaming docker lint script file (#5937) * fix: err handling for configmap access * release: PR for v0.7.3 (#5942) * Update Chart.yaml * Update devtron-bom.yaml * Update values.yaml * Update devtron-installer.yaml * Update installation-script * Update version.txt * Update devtron.yaml * Update releasenotes.md * Update devtron-bom.yaml * Update values.yaml * Update releasenotes.md * Update releasenotes.md * Updated release-notes files * Update releasenotes.md * Update release.txt * Updated release-notes files * Update release-notes-v0.7.2.md --------- Co-authored-by: ReleaseBot <[email protected]> * wip: modifying tags function * sync --------- Co-authored-by: Gireesh Naidu <[email protected]> Co-authored-by: Gireesh Naidu <[email protected]> Co-authored-by: kamal-devtron <[email protected]> Co-authored-by: Kiran <[email protected]> Co-authored-by: Prakarsh <[email protected]> Co-authored-by: Pawan Mehta <[email protected]> Co-authored-by: ReleaseBot <[email protected]>
vikramdevtron
added a commit
that referenced
this pull request
Oct 3, 2024
* fix: app update migration (#5903) * wip: adding app name check * wip * wip * wip * moving migration to code * wip: adding app name in log * wip: moving sql logic to code * pg no rows handling * adding db migration call * fixing fetch app query * wip: adding pg multiple rows handling * audit log update * fix: nil ptr fix in copying extraEnvVars * feat: Docker lint plugin (#5694) * added up script for docker linit plugin * rename of script file * docker lint down script * changes in docker lint * hadolint image * change in name of plugin * changes in down script * chnages in docker lint * chnages in down script * change in hadolint image * rename down script file * renaming sql script * feat: Added Devtron CI Trigger v1.1.0 (#5934) * Create 028901_019_devtron_ci_trigger_v1_1.down.sql * Create 028901_019_devtron_ci_trigger_v1_1.up.sql * Update 028901_019_devtron_ci_trigger_v1_1.up.sql --------- Co-authored-by: Prakarsh <[email protected]> * renaming docker lint script file (#5937) * fix: err handling for configmap access * release: PR for v0.7.3 (#5942) * Update Chart.yaml * Update devtron-bom.yaml * Update values.yaml * Update devtron-installer.yaml * Update installation-script * Update version.txt * Update devtron.yaml * Update releasenotes.md * Update devtron-bom.yaml * Update values.yaml * Update releasenotes.md * Update releasenotes.md * Updated release-notes files * Update releasenotes.md * Update release.txt * Updated release-notes files * Update release-notes-v0.7.2.md --------- Co-authored-by: ReleaseBot <[email protected]> --------- Co-authored-by: iamayushm <[email protected]> Co-authored-by: Gireesh Naidu <[email protected]> Co-authored-by: Gireesh Naidu <[email protected]> Co-authored-by: kamal-devtron <[email protected]> Co-authored-by: Kiran <[email protected]> Co-authored-by: Prakarsh <[email protected]> Co-authored-by: Pawan Mehta <[email protected]> Co-authored-by: ReleaseBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5914
Checklist:
Does this PR introduce a user-facing change?